feat(redisotel): Update redis otel with option to not set raw command as an attribute #2194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wildefires
changed the title
|
Updated the PR title to match the commitlint spec (I think) - if someone can show me how to kick it off again that'd be great 🙃 |
vmihailenco
reviewed
Sep 3, 2022
| @@ -136,3 +142,10 @@ func WithAttributes(attrs ...attribute.KeyValue) Option { | |||
| cfg.attrs = append(cfg.attrs, attrs...) | |||
| }) | |||
| } | |||
|
|
|||
| // WithIgnoreRawCmd tells the tracing hook not to log raw redis commands. | |||
| func WithIgnoreRawCmd() Option { | |||
There was a problem hiding this comment.
Let's rename this to WithDBStatement(true/false) so it can be more easily enabled/disabled - https://uptrace.dev/blog/posts/go-functional-options-named-args.html#bool-options
|
@Cull-Methi aside from the option name this looks pretty good. Could you update the name? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to not set the db.statement attribute, closes #2195