Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redisotel should allow an option to not set the raw cmd as an attribute on spans #2195

Closed
wildefires opened this issue Aug 26, 2022 · 1 comment
Labels

Comments

@wildefires
Copy link

wildefires commented Aug 26, 2022

We've run into issues where big queries have caused services to OOM when trying to put them as span tags (in the datadog tracing world), see DataDog/dd-trace-go#1022

Additionally, there's a security aspect to be considered as the query - with its params - could contain sensitive information that we wouldn't want to put into a plaintext storage (like span attributes).

As such, I think the redisotel package should allow an option to not use the command as an attribute

Expected Behavior

There should be a way to disable the command as an attribute.

Current Behavior

There is not a way to disable it.

Possible Solution

Allow an option to be provided at hook creation time to disable adding the attribute, see #2194

Steps to Reproduce

  1. Use otelredis
  2. notice that spans have the db statement attribute
  3. notice there's no way to disable it

Context (Environment)

Environment independent

Detailed Description

See top

Possible Implementation

#2194

@github-actions
Copy link

This issue is marked stale. It will be closed in 30 days if it is not updated.

@github-actions github-actions bot added the Stale label Sep 21, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant