Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Improve Subs/CSV validation" #454

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Revert "Improve Subs/CSV validation" #454

merged 1 commit into from
Oct 3, 2024

Conversation

betoredhat
Copy link
Contributor

@betoredhat betoredhat commented Oct 3, 2024 •
edited
Loading

@betoredhat betoredhat requested a review from a team as a code owner October 3, 2024 16:05
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/6c56938681bd4d8eab0ad0c8f84a58a0

✔️ dci-rpm-build-el8 SUCCESS in 2m 47s
✔️ dci-rpm-build-el9 SUCCESS in 2m 17s

@betoredhat betoredhat mentioned this pull request Oct 3, 2024
Merged
1 task
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/da70ea9d008b4ec097dae29a088089d5

✔️ dci-rpm-build-el8 SUCCESS in 2m 55s
✔️ dci-rpm-build-el9 SUCCESS in 2m 32s

@dcibot
Copy link
Collaborator

dcibot commented Oct 3, 2024

from change #454:

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/0582d4e5fbc24a7997d4356a84c3332c

✔️ dci-rpm-build-el8 SUCCESS in 2m 45s
✔️ dci-rpm-build-el9 SUCCESS in 2m 31s

@dcibot
Copy link
Collaborator

dcibot commented Oct 3, 2024

from change #454:

tonyskapunk
tonyskapunk approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@tonyskapunk tonyskapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@betoredhat betoredhat removed the request for review from manurodriguez October 3, 2024 21:27
@betoredhat betoredhat added this pull request to the merge queue Oct 3, 2024
Merged via the queue into main with commit 4df2721 Oct 3, 2024
7 checks passed
@betoredhat betoredhat deleted the revert-452-fix_csv branch October 3, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyskapunk tonyskapunk tonyskapunk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@betoredhat @dcibot @tonyskapunk