Improve Subs/CSV validation

[betoredhat]

SUMMARY

• installPlanApproval for the initial subscription must be Automatic to complete the installation.
• Use installedCSV to validate the subscription as it represents the current version installed. currentCSV represents the version available for upgrading.

ISSUE TYPE

• Bug, Docs Fix or other nominal change

Tests

• TestBos2 - https://www.distributed-ci.io/jobs/d334c5cf-05f1-441b-9925-ec4a2738c625/jobStates

[softwarefactory-project-zuul]

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/c7e56629284944429965b34f8eaf68aa

✔️ dci-rpm-build-el8 SUCCESS in 2m 49s
✔️ dci-rpm-build-el9 SUCCESS in 2m 29s

[dcibot]

from change #452:

• SUCCESS https://www.distributed-ci.io/jobs/d334c5cf-05f1-441b-9925-ec4a2738c625/jobStates

[tonyskapunk]

LGTM!! 💯

[nsilla]

I'd wish I had seen this PR before it got approved but I see it's causing some jobs to fail.

https://www.distributed-ci.io/jobs/1fd1de75-5ecf-4a0e-aa7f-73549c216797/jobStates?sort=date&task=dd157386-954d-41eb-b1a5-4be22f6b420c

The problem is hardcoding the approval method to "Automatic" is not compatible with using the starting_csv parameter.

With the automatic approval method, the OLM will install the starting_csv and then keep upgrading the CSVs until it reaches the currentCSV.

To start with, this renders the starting_csv parameter without effect, but, furthermore, when the olm_operator role waits for the subscription to be ready, the condition is that the installedCSV has the same value as the operator_csv variable, which is set to the starting_csv if set. As you can see in the linked job, with the automatic approval method these values are bound not to match and thus the job will fail.

[betoredhat]

ouch, no worries... time travel is now possible. The following revert change will do the trick: #454. Will wait for you next time. :)