-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update token permissions documentation 🗝️ #418
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #418 +/- ##
=======================================
Coverage 85.71% 85.71%
=======================================
Files 5 5
Lines 315 315
=======================================
Hits 270 270
Misses 45 45 ☔ View full report in Codecov by Sentry. |
README.md
Outdated
* Token with the `security_events: write` scope to use this endpoint for private repositories. | ||
* Token with the `public_repo` scope for **public repositories only**. | ||
* `security_events: write` scope for **all repositories**. | ||
* `actions: read` and `contents: read` scopes for **private repositories only**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably worth phrasing in a way to be clear that the private repo requirements are "in addition to" as opposed to "instead of"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I have tried to make it a bit more straightforward. I hope it helps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! (it would be nice if github made more of this official in the action.yml format. having a structured format for what permissions are required, under what circumstances, and be consistent between actions would be nice)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with this 100%
i appreciate the additional clarity! |
No description provided.