Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token permissions confusion #417

Closed
jasonkarns opened this issue Jun 2, 2024 · 2 comments · Fixed by #418
Closed

Token permissions confusion #417

jasonkarns opened this issue Jun 2, 2024 · 2 comments · Fixed by #418
Assignees
Labels

Comments

@jasonkarns
Copy link

Type of issue

other

Description

The readme seems to show conflicting information regarding the permissions necessary for the token.

In the sample workflow it indicates security-events: write is required for all workflows. (as opposed to private repo workflows).

But under the token docs, it contradicts that statement:

Token with the public_repo scope for public repositories only.

Describe the solution you'd like

Through trial and error it became clear that security-events: write is indeed necessary for public repos. (contradicting the docs for token in the readme) But only if using the action itself to upload? One could skip the upload, or use github's own codeql action to upload which would presumably only require contents: read for this action?

Either way, I think this confusion could be cleared up a bit.

@jamacku
Copy link
Member

jamacku commented Jun 7, 2024

Thank you for reporting this documentation issue. It's indeed misleading.

security-events: write is required for all workflows. Unfortunately, the token section of the documentation wasn't updated accordingly.

@jamacku jamacku linked a pull request Jun 7, 2024 that will close this issue
@jamacku
Copy link
Member

jamacku commented Jun 7, 2024

@jasonkarns, I would appreciate your review on:

Thank you

@jamacku jamacku self-assigned this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants