Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better UX when generating a Quarkus project #310

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Better UX when generating a Quarkus project #310

merged 1 commit into from
Oct 15, 2020

Conversation

azatsarynnyy
Copy link
Member

@azatsarynnyy azatsarynnyy commented Oct 9, 2020 •
edited
Loading

Signed-off-by: Artem Zatsarynnyi [email protected]

closes #309
also closes downstream Che issue eclipse-che/che#18006

This was referenced Oct 12, 2020
Closed
Closed
rgrunber
rgrunber reviewed Oct 13, 2020
View reviewed changes
Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change definitely improves the situation for the wizard creation. Much nicer to have the current workspace folder. Just one minor issue I found.

src/wizards/generateProject/generationWizard.ts Show resolved Hide resolved
@azatsarynnyy azatsarynnyy mentioned this pull request Oct 15, 2020
Closed
@fbricon
Copy link
Collaborator

fbricon commented Oct 15, 2020 •
edited
Loading

Ideally, we should even preselect the last opened (parent) folder, where a previous project was generated.

@rgrunber rgrunber merged commit 26316e0 into redhat-developer:master Oct 15, 2020
@azatsarynnyy azatsarynnyy deleted the defDirUri branch October 16, 2020 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsmaeder tsmaeder tsmaeder left review comments

@rgrunber rgrunber rgrunber left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better UX when generating a Quarkus project
4 participants
@azatsarynnyy @fbricon @rgrunber @tsmaeder