Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workspace.workspaceFolders API should return undefined when no folder is open #8640

Closed
azatsarynnyy opened this issue Oct 15, 2020 · 1 comment · Fixed by #8641
Closed

workspace.workspaceFolders API should return undefined when no folder is open #8640

azatsarynnyy opened this issue Oct 15, 2020 · 1 comment · Fixed by #8641
Labels
bug bugs found in the application plug-in system issues related to the plug-in system Team: Che-Editors issues regarding the che-editors team vscode issues related to VSCode compatibility
Milestone
1.7.0

Comments

@azatsarynnyy
Copy link
Member

Bug Description:

workspace.workspaceFolders Plugin API should return undefined when no folder is open. But it returns an empty array. It leads to the failure of some VS Code extensions that rely on undefined value.

Steps to Reproduce:

  1. Put the test plugin into the plugins folder and run Theia.
  2. Call Hello World command from the Commands Palette when no workspace folder is opened.
  3. It shows the message ws api returns 0 workspace folders, but has to show no workspace folders as it is in VS Code.

Additional Information

  • Operating System:
  • Theia Version: 1.6.0
@azatsarynnyy azatsarynnyy added bug bugs found in the application plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility labels Oct 15, 2020
@azatsarynnyy
Copy link
Member Author

An example of the issue in VS Code extension redhat-developer/vscode-quarkus#310 (comment)

@azatsarynnyy azatsarynnyy mentioned this issue Oct 15, 2020
Merged
@azatsarynnyy azatsarynnyy added the Team: Che-Editors issues regarding the che-editors team label Oct 15, 2020
@azatsarynnyy azatsarynnyy added this to the 1.7.0 milestone Oct 15, 2020
This was referenced Oct 15, 2020
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application plug-in system issues related to the plug-in system Team: Che-Editors issues regarding the che-editors team vscode issues related to VSCode compatibility
Projects
None yet
Milestone
1.7.0
Development

Successfully merging a pull request may close this issue.

workspace.workspaceFolders API should return undefined when no folder is open eclipse-theia/theia
1 participant
@azatsarynnyy