Address warnings from CI build (update github actions) #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lavanyaj3 <[email protected]>
This reverts commit 6bb4fff.
Run Test step is split into two parts: one for Linux (using Xvfb) and another for macOS (which does not need Xvfb) Signed-off-by: lavanyaj3 <[email protected]>
|
Please don't remove the comments |
fbricon
reviewed
Oct 24, 2024
.github/workflows/build.yaml
Outdated
Comment on lines
49
to
56
| # Install Xvfb | ||
| sudo apt-get update | ||
| sudo apt-get install -y xvfb | ||
| # Start Xvfb | ||
| Xvfb :99 -screen 0 1920x1080x24 & | ||
| export DISPLAY=:99 | ||
| # Run your tests | ||
| npm test |
There was a problem hiding this comment.
whole setup is unnecessary, as xvfb is available on ubuntu runners now.
See:
fbricon
reviewed
Oct 24, 2024
.github/workflows/build.yaml
Outdated
| npm test | ||
|
|
||
| - name: Run Test on macOS | ||
| if: runner.os == 'macOS' |
There was a problem hiding this comment.
runner.os != 'Linux'
we'll need to run tests on windows (but that's another issue)
There was a problem hiding this comment.
Run tests
- name: Run Tests
run: |
if [ "${{ runner.os }}" == "Linux" ]; then
xvfb-run npm test
else
npm test
fi
Made the changes accordingly
Signed-off-by: lavanyaj3 <[email protected]>
fbricon
approved these changes
Oct 24, 2024
|
thanks @lavanyaj3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address warnings from CI build (update github actions)
Fixes: #106