-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This action is no longer needed, GitHub Actions (ubuntu) ships with xvfb #21
Comments
Thanks for linking the documentation. It was believed that this installation could have been an accident or some form of experimentation. We couldn't find a documentation noting XVFB officially so we continued to use the action. ✅ Support |
see [this](coactions/setup-xvfb#21)
This action works on all OS, while the GA one works only on Linux |
As it turns out (see coactions/setup-xvfb#21), it is available in our container anyway. Also pin the Python version to 3.11. Change-Id: Id8d2416996ea489675ca7e50da59286af1965777
- if: runner.os == 'Linux'
run: xvfb-run npm test
- if: runner.os != 'Linux'
run: npm test |
Fixes coactions#21 An alternative proposal to coactions#30 * coactions#21 * coactions#30
This is still not really an alternative as one now needs to replicate all steps in a matrix, so can this action not simply wrap the call if appropriate and be a noop otherwhise? |
See at the bottom of: https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md
And a successful run at https://github.com/fregante/text-field-edit/actions/runs/6107546540/workflow#L28
I'd probably add a notice to the repo and/or deprecate it.
The text was updated successfully, but these errors were encountered: