Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(theme): fix font loading after migrating theme #202

Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix(theme): fix font loading after migrating theme #202

merged 1 commit into from
Dec 19, 2024

Conversation

christoph-jerolimov
Copy link
Member

@christoph-jerolimov christoph-jerolimov commented Dec 16, 2024 •
edited
Loading

Hey, I just made a Pull Request!

TODO

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

@christoph-jerolimov christoph-jerolimov self-assigned this Dec 16, 2024
@rhdh-gh-app
Copy link

rhdh-gh-app bot commented Dec 16, 2024

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-theme workspaces/theme/plugins/theme patch v0.4.7

@christoph-jerolimov christoph-jerolimov mentioned this pull request Dec 18, 2024
Closed
4 tasks
ciiay
ciiay reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@ciiay ciiay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified with yarn link on local showcase and it works as expected. The mui/material version is not compatible to the showcase one. Did you have to match the version or it worked out with no extra step for you?

workspaces/theme/plugins/theme/package.json Show resolved Hide resolved
@ciiay ciiay mentioned this pull request Dec 19, 2024
Merged
4 tasks
@ciiay
Copy link
Contributor

ciiay commented Dec 19, 2024

/lgtm

Thank you 🤝

@openshift-ci openshift-ci bot added the lgtm label Dec 19, 2024
@debsmita1 debsmita1 merged commit 1134fb2 into redhat-developer:main Dec 19, 2024
7 checks passed
@christoph-jerolimov christoph-jerolimov deleted the fix-theme-font-usage branch December 19, 2024 07:57
@christoph-jerolimov christoph-jerolimov mentioned this pull request Dec 19, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debsmita1 debsmita1 debsmita1 approved these changes

@ciiay ciiay Awaiting requested review from ciiay ciiay is a code owner

Assignees

@christoph-jerolimov christoph-jerolimov

@ciiay ciiay

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christoph-jerolimov @ciiay @debsmita1