Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): replace style-inject(ion) workaround with @backstage/cli update #141

Conversation

christoph-jerolimov
Copy link
Member

Hey, I just made a Pull Request!

Fix a style-inject(ion) issue with the published package that I noticed in redhat-developer/rhdh#2033

See build log: https://github.com/janus-idp/backstage-showcase/actions/runs/12196430482/job/34023993902?pr=2033

Solved issue by updating @backstage/cli to a version that includes backstage/backstage#27547

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

@rhdh-gh-app
Copy link

rhdh-gh-app bot commented Dec 6, 2024

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-theme workspaces/theme/plugins/theme patch v0.4.5

@christoph-jerolimov christoph-jerolimov changed the title fix(theme): fix style-inject(ion) issue with the published package fix(theme): fix style-inject(ion) issue with the published package via updating @backstage/cli Dec 6, 2024
@christoph-jerolimov christoph-jerolimov marked this pull request as draft December 6, 2024 10:18
@christoph-jerolimov christoph-jerolimov changed the title fix(theme): fix style-inject(ion) issue with the published package via updating @backstage/cli fix(theme): replace style-inject(ion) workaround with @backstage/cli update Dec 6, 2024
@christoph-jerolimov
Copy link
Member Author

#202 will address this issue in a much better way.

@christoph-jerolimov christoph-jerolimov deleted the fix-style-inject-issue branch December 18, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant