-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Support against IC-2024.2+ #246
Conversation
Signed-off-by: Stephane Bouchet <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>
@adietish ready for review ! |
enabled = false | ||
} | ||
|
||
// infamous hack, see https://github.com/gradle-nexus/publish-plugin/issues/354 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for now this is the only solution i found to make the publish pass.
if buildSearchableOptions is set to true, build fails because there is no plugin.xml
if buildSearchableOPtions is set to false, thepubish task fails with this file not found...
FYI, there is no such jar uploaded to nexus with older versions
Signed-off-by: Stephane Bouchet <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Looks good and builds fine.
Kudos, discovered several hurdles taken, must have been quite a fight.
Suggested to comment why searchable hint is set to false.
plugins(providers.gradleProperty("platformPlugins").map { it.split(',') }) | ||
|
||
// for local plugin -> https://plugins.jetbrains.com/docs/intellij/tools-gradle-intellij-plugin-faq.html#how-to-add-a-dependency-on-a-plugin-available-in-the-file-system | ||
//plugins.set(listOf(file("/path/to/plugin/"))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this inline hint!
@@ -1,6 +1,7 @@ | |||
distributionBase=GRADLE_USER_HOME | |||
distributionPath=wrapper/dists | |||
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.1-all.zip | |||
distributionUrl=https\://services.gradle.org/distributions/gradle-8.5-bin.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yay, long awaited bump to gradle 8.5. Nice.
@@ -23,7 +23,9 @@ jobs: | |||
- name: Grant execute permission for gradlew | |||
run: chmod +x gradlew | |||
- name: Build with Gradle | |||
run: ./gradlew build --continue -PideaVersion=LATEST-EAP-SNAPSHOT | |||
run: | | |||
LATEST-EAP-SNAPSHOT=$(./gradlew printProductsReleases | grep 'IC-' | head -n 1 | cut -d'-' -f2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like "LATEST-EAP-SNAPSHOT" doesnt exist any more since you query and parse?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, the LATEST-EAP-SNAPSHOT variable is not recognized anymore using gradle plugin 2.X.
see https://plugins.jetbrains.com/docs/intellij/tools-intellij-platform-gradle-plugin-faq.html#how-to-check-the-latest-available-eap-release
Signed-off-by: Stephane Bouchet <[email protected]>
Quality Gate passedIssues Measures |
fixes #243