fix: replace HttpConfigurable with adapter to support pre/post-2024.3 (#242)

[adietish]

fixes #242, #255
depends on

• Support building against IC-2024.2+ #243
• Support 2024.2  intellij-openshift-connector#889 (can only test this using intellij-openshift-connector who's a consumer of this API)

[adietish]

putting this on hold, waiting for #246

[adietish]

@sbouchet: Tested it in intellij-openshift-connector with IU-2024.1 using our internal proxy. Patch worked, the plugin picked the proxy.
Now waiting for intellij-openshift-connector to compile against IU-2024.2 as in redhat-developer/intellij-openshift-connector#889 to test this patch against EAP of IU-2024.3.

[adietish]

@sbouchet tested and corrected the patch to work with latest EAP (243.21565.23). Works for me in 2024.1 and 243.21565.23.
I found out somethid odd though. The existing code (pre-patch) doesn't use proxy credentials that were provided in the settings.

The following (existing) code returns null even if you provided username & password in the settings:

new IdeaWideAuthenticator(HttpConfigurable.getInstance()).getPasswordAuthentication()

The following works on the other hand:

HttpConfigurable.getInstance().getPromptedAuthentication(url, null)

[adietish]

Turns out that the reason is as follows:

1. IdeaWideAuthenticator(HttpConfigurable.getInstance()).getPasswordAuthentication() checks the requestorType using ideaWideAuthenticator.getRequestorType().
2. The type is null.
3. IdeaWideAuthenticator.getPasswordAuthentication() therefore ignores the credentials.

https://github.com/JetBrains/intellij-community/blob/f020cd7ad5d49fa5baf4ed526e03d20af690bdb6/platform/platform-api/src/com/intellij/util/net/IdeaWideAuthenticator.java#L32:

public final class IdeaWideAuthenticator extends NonStaticAuthenticator {
  private static final Logger LOG = Logger.getInstance(IdeaWideAuthenticator.class);
  private final HttpConfigurable myHttpConfigurable;

  public IdeaWideAuthenticator(@NotNull HttpConfigurable configurable) {
    myHttpConfigurable = configurable;
  }

  @Override
  public synchronized PasswordAuthentication getPasswordAuthentication() {
    final String host = CommonProxy.getHostNameReliably(getRequestingHost(), getRequestingSite(), getRequestingURL());
    // java.base/java/net/SocksSocketImpl.java:176 : there is SOCKS proxy auth, but without RequestorType passing
    final boolean isProxy = Authenticator.RequestorType.PROXY.equals(getRequestorType()) || "SOCKS authentication".equals(getRequestingPrompt());
    // FIXME prefix for server auth is never used since 7ea74ea400b03cf92d1621ea0e8aa1d386cb886a.
    //  This means that this class manages strictly proxy authentication since 2013

I believe that this is a platform bug. The new API fixes this issue.

[adietish]

@sbouchet: please review

ps. current EAP 2024.3 is IC-243.21565.23. It still has the API that's marked as "for removal". So to test if this PR works for it, you'd have to comment out the pre-2024.3 variants in IdeProxyAdapter

gradle.properties:

platformVersion=243.21565.23

As a proxy you can use the internal squid that's available beind VPN. You'd have to set the proxy in the runtime IDE and restart it.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[sbouchet]

LGTM.