Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DownloadHelper#downloadIfRequired allows to know if was downloaded #228

Merged
merged 1 commit into from
May 7, 2024

Conversation

adietish
Copy link
Contributor

fixes #227

@adietish adietish requested a review from sbouchet April 26, 2024 15:19
@adietish adietish self-assigned this Apr 26, 2024
@adietish adietish changed the title DownloadHelper#downloadIfRequired returns Command feat: DownloadHelper#downloadIfRequired returns Command Apr 26, 2024
@adietish adietish force-pushed the issue-227 branch 2 times, most recently from 249fbff to dd92d60 Compare April 26, 2024 18:13
@adietish adietish changed the title feat: DownloadHelper#downloadIfRequired returns Command feat: DownloadHelper#downloadIfRequired allows to know if was downloaded Apr 26, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@adietish
Copy link
Contributor Author

adietish commented May 6, 2024

@sbouchet: please review. Thanks! This update in intellij-common is needed for redhat-developer/intellij-openshift-connector#809

Copy link
Contributor

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adietish adietish merged commit 1ecbc93 into redhat-developer:main May 7, 2024
10 checks passed
@adietish adietish deleted the issue-227 branch May 7, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DownloadHelper#downloadIfRequired needs to tell caller if binary was downloaded
2 participants