fix: dont refresh tree if binary is not downloaded (#802)

[adietish]

fixes #802
depends on redhat-developer/intellij-common#228

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[adietish]

@sbouchet: we're back at jenkins not authenticating against nexus. Intellij-common 1.9.6-SNAPSHOT is thus missing and this PR not compiling:

[2024-05-08T16:38:13.310Z] * What went wrong:
[2024-05-08T16:38:13.310Z] Execution failed for task ':publishMavenJavaPublicationToJbossNexusRepository'.
[2024-05-08T16:38:13.310Z] > Failed to publish publication 'mavenJava' to repository 'jbossNexus'
[2024-05-08T16:38:13.310Z] > Could not PUT 'https://repository.jboss.org/nexus/content/repositories/snapshots/com/redhat/devtools/intellij/intellij-common/1.9.6-SNAPSHOT/maven-metadata.xml'. Received status code 401 from server: Unauthorized
[2024-05-08T16:38:13.310Z]

[sbouchet]

@adietish integration Tests have compilation failures :

/home/runner/work/intellij-openshift-connector/intellij-openshift-connector/src/it/java/org/jboss/tools/intellij/openshift/utils/helm/HelmCliTest.java:29: error: incompatible types: Tool<Odo> cannot be converted to Odo
> Task :compileIntegrationTestJava FAILED
        Odo odo = ToolFactory.getInstance().createOdo(getProject()).get();
                                                                       ^
/home/runner/work/intellij-openshift-connector/intellij-openshift-connector/src/it/java/org/jboss/tools/intellij/openshift/utils/helm/HelmCliTest.java:32: error: incompatible types: Tool<Helm> cannot be converted to Helm
        this.helm = ToolFactory.getInstance().createHelm(getProject()).get();
                                                                          ^
/home/runner/work/intellij-openshift-connector/intellij-openshift-connector/src/it/java/org/jboss/tools/intellij/openshift/utils/helm/HelmCliTest.java:38: error: incompatible types: Tool<Odo> cannot be converted to Odo
        Odo odo = ToolFactory.getInstance().createOdo(getProject()).get();
                                                                       ^
/home/runner/work/intellij-openshift-connector/intellij-openshift-connector/src/it/java/org/jboss/tools/intellij/openshift/utils/ToolFactoryTest.java:22: error: incompatible types: Tool<Odo> cannot be converted to Odo
        Odo odo = ToolFactory.getInstance().createOdo(getProject()).get();
                                                                       ^
/home/runner/work/intellij-openshift-connector/intellij-openshift-connector/src/it/java/org/jboss/tools/intellij/openshift/utils/ToolFactoryTest.java:27: error: incompatible types: Tool<Helm> cannot be converted to Helm
        Helm helm = ToolFactory.getInstance().createHelm(getProject()).get();
                                                                          ^
/home/runner/work/intellij-openshift-connector/intellij-openshift-connector/src/it/java/org/jboss/tools/intellij/openshift/utils/odo/OdoCliTest.java:89: error: incompatible types: Tool<Odo> cannot be converted to Odo
      .thenApply(odoDelegate -> new ApplicationRootNodeOdo(odoDelegate, mock(ApplicationsRootNode.class), processHelper));

[adietish]

@sbouchet: corrected. Please re-review. thanks.

[adietish]

@sbouchet please review

[sonarqubecloud]

Quality Gate failed

Failed conditions
28.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

[adietish]

/override ci/prow/e2e-openshift

[openshift-ci]

@adietish: Overrode contexts on behalf of adietish: ci/prow/e2e-openshift

In response to this:

/override ci/prow/e2e-openshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sbouchet]

LGTM. very good UI contribution !

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbouchet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbouchet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment