Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated delete method #882

Merged
merged 1 commit into from
Feb 16, 2017
Merged

Updated delete method #882

merged 1 commit into from
Feb 16, 2017

Conversation

cashhh
Copy link
Contributor

@cashhh cashhh commented Feb 15, 2017

The delete method now takes another argument for 'data' like its sibling methods do and uses the 'send' prototype to pass the data.

@gigabo
Copy link
Contributor

gigabo commented Feb 16, 2017

Thanks @cashhh. Nice to have this consistent with the other methods. 👍

@drewpc drewpc added the enhancement New functionality. label Feb 16, 2017
@drewpc drewpc added this to the 0.6.1 milestone Feb 16, 2017
@drewpc drewpc merged commit ab4e423 into redfin:master Feb 16, 2017
@drewpc drewpc mentioned this pull request Feb 16, 2017
Closed
@drewpc drewpc added bug An issue with the system good first contribution and removed enhancement New functionality. labels Feb 16, 2017
@cashhh
Copy link
Contributor Author

cashhh commented Feb 16, 2017

Awesome. Glad I could help.

@cashhh cashhh deleted the fixing-delete-method branch February 16, 2017 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewpc drewpc drewpc approved these changes

@gigabo gigabo gigabo approved these changes

Assignees
No one assigned
Labels
bug An issue with the system
Projects
None yet
Milestone
0.6.1
Development

Successfully merging this pull request may close these issues.
3 participants
@cashhh @gigabo @drewpc