Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactServerAgent.del doesn't accept post args #841

Closed
roblg opened this issue Jan 20, 2017 · 2 comments
Closed

ReactServerAgent.del doesn't accept post args #841

roblg opened this issue Jan 20, 2017 · 2 comments
Labels
bug An issue with the system

Comments

@roblg
Copy link
Member

roblg commented Jan 20, 2017

Expected: the following should work

ReactServerAgent.del('/foo', {foo: "bar"}).then(() => { ... })

Actual: it doesn't.

I believe this works though:

ReactServerAgent.del('/foo').send({foo: "bar"}).then(() => { ... });

Looks like ReactServerAgent.del doesn't follow the same pattern as its siblings in allowing the shorthand. Seems like it should.

@roblg roblg added bug An issue with the system good first contribution labels Jan 20, 2017
@cashhh
Copy link
Contributor

cashhh commented Feb 15, 2017

I'd like to give this a shot

@drewpc
Copy link
Collaborator

drewpc commented Feb 16, 2017

Fixed in #882

@drewpc drewpc closed this as completed Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue with the system
Projects
None yet
Development

No branches or pull requests

3 participants