-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sjv improve error logging #597
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,134 @@ | ||
import Q from "q"; | ||
import Q from 'q'; | ||
import { Component } from 'react'; | ||
import { RootElement } from 'react-server'; | ||
|
||
import {RootElement} from "react-server"; | ||
class RenderError extends Component { | ||
render() { | ||
throw new Error('Error in render'); | ||
} | ||
} | ||
|
||
const ReceiveProps = OriginalComponent => class extends Component { | ||
constructor(props) { | ||
super(props); | ||
this.state = { | ||
randomProp: Math.random(), | ||
}; | ||
} | ||
updateState() { | ||
this.setState({ | ||
randomProp: Math.random(), | ||
}); | ||
} | ||
render() { | ||
return ( | ||
<h2> | ||
<button onClick={this.updateState.bind(this)}> | ||
Click to update props | ||
</button> | ||
<OriginalComponent {...this.state}/> | ||
</h2> | ||
); | ||
} | ||
}; | ||
|
||
const ComponentWillReceivePropsError = ReceiveProps( | ||
class extends Component { | ||
componentWillReceiveProps(nextProps) { | ||
throw Error('Error in componentWillReceiveProps'); | ||
} | ||
render() { | ||
return <span>componentWillReceiveProps error</span>; | ||
} | ||
} | ||
); | ||
|
||
const ComponentDidReceivePropsError = ReceiveProps( | ||
class extends Component { | ||
componentDidReceiveProps(nextProps) { | ||
throw Error('Error in componentDidReceiveProps'); | ||
} | ||
render() { | ||
return <span>componentDidReceiveProps error</span>; | ||
} | ||
} | ||
); | ||
|
||
const ComponentWillUpdateError = ReceiveProps( | ||
class extends Component { | ||
componentWillUpdate(nextProps, nextState) { | ||
throw Error('Error in componentWillUpdate'); | ||
} | ||
render() { | ||
return <span>componentWillUpdate error</span>; | ||
} | ||
} | ||
); | ||
|
||
const ComponentDidUpdateError = ReceiveProps( | ||
class extends Component { | ||
componentDidUpdate(prevProps, prevState) { | ||
throw Error('Error in componentDidUpdate'); | ||
} | ||
render() { | ||
return <span>componentDidUpdate error</span>; | ||
} | ||
} | ||
); | ||
|
||
class ComponentDidMountError extends Component { | ||
componentDidMount() { | ||
throw Error('Error in componentDidMount'); | ||
} | ||
render() { | ||
return <h2>componentDidMount Error</h2>; | ||
} | ||
} | ||
|
||
class ComponentWillMountError extends Component { | ||
componentWillMount() { | ||
throw Error('Error in componentWillMount'); | ||
} | ||
render() { | ||
return <h2>componentWillMount Error</h2>; | ||
} | ||
} | ||
|
||
function fail() { | ||
return Q().then(() => { throw new Error("Fail!") }); | ||
return Q().then(() => { throw new Error('Fail'); }); | ||
} | ||
|
||
const RootElementWhenPromiseFailure = (props => | ||
<RootElement when={fail()}> | ||
<h2>RootElement when=failed promise</h2> | ||
</RootElement> | ||
); | ||
|
||
class MissingKeyPropInArrayIterator extends Component { | ||
render() { | ||
return ( | ||
<div> | ||
<h2>Missing Key Prop in Array Iterator Warning</h2> | ||
{ [1,2,3,4].map(n => <span>{n}</span>) } | ||
</div> | ||
); | ||
} | ||
} | ||
|
||
export default class ErrorLogsPage { | ||
export default class ErrorReportingPage { | ||
getElements() { | ||
return [ | ||
<div>Check the logs</div>, | ||
<RootElement when={fail()}>Nope</RootElement>, | ||
] | ||
<h1>Error Logging Tests</h1>, | ||
<h2>Render error</h2>, | ||
<RenderError/>, | ||
<ComponentWillMountError/>, | ||
<ComponentDidMountError/>, | ||
<ComponentWillReceivePropsError/>, | ||
<ComponentDidReceivePropsError/>, | ||
<ComponentWillUpdateError/>, | ||
<ComponentDidUpdateError/>, | ||
<RootElementWhenPromiseFailure/>, | ||
<MissingKeyPropInArrayIterator/>, | ||
]; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoa, does this always work? Can we ditch
PageUtil.getElementDisplayName
(or gut it and put this in there)?