Sjv improve error logging #597
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // The only case where this should evaluate to false is | ||
| // when `element` is a containerClose/containerOpen object | ||
| const componentType = typeof element.type === 'function' | ||
| ? element.props.children.type.name |
There was a problem hiding this comment.
Whoa, does this always work? Can we ditch PageUtil.getElementDisplayName (or gut it and put this in there)?
|
@SteveVitali This is awesome! @lidawang Have you seen this?! |
|
Hrm... travis doesn't like it. I'll pull it down and see if I can figure out what's going on with the build. |
|
Oh... @SteveVitali looks like you're on a pretty (~1 month) old base. A rebase onto current master might clear up the travis error. |
|
Thanks @SteveVitali. Closing this in favor of #626. @lidawang has preserved your authorship there, and we won't squash the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys, these are some changes from the hackathon a few weeks ago that I never got around to making a PR for.