Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dash-delimited options in .reactserverrc #783

Open
gigabo opened this issue Dec 5, 2016 · 10 comments
Open

Support dash-delimited options in .reactserverrc #783

gigabo opened this issue Dec 5, 2016 · 10 comments
Labels
enhancement New functionality.

Comments

@gigabo
Copy link
Contributor

gigabo commented Dec 5, 2016

The CLI supports options both --camelCase and --dash-delimited.

The .reactserverrc config file only supports camelCase keys.

We should make the config file support both also to eliminate frustrating behavior.

gigabo referenced this issue Dec 5, 2016
* Add cli option for webpack-config

* Add more doc

* Doc edits

* Update documentation based off pr feedback
@markthethomas
Copy link
Contributor

@gigabo I can take this on if it's still a thing, looking to help out where I can w/ the project 👍

@gigabo
Copy link
Contributor Author

gigabo commented Jan 9, 2017

@markthethomas Awesome! This will make the UI more consistent / less confusing. Thanks for taking it on!

@markthethomas
Copy link
Contributor

markthethomas commented Jan 9, 2017 via email

@markthethomas
Copy link
Contributor

@gigabo I'd also be interested in helping clear up some of the docs and/or helping w/ the component API documentation, there are a few things I've run into when integrating this w/ my projects that I've yet to overcome all the way 👍 think I saw a few other issues where this came up

@markthethomas
Copy link
Contributor

@gigabo is there any general objection to bringing in deps to address things like this? was thinking of decamelize, which I think yargs already depends on and uses to address this case. jw before I commit and PR anything 👍

@doug-wade
Copy link
Collaborator

Generally, we're trying to head in the opposite direction, per #277. If, however, decamelize is already in our dependency closure, and yargs doesn't have a way to support this natively, then I don't see any harm.

@markthethomas
Copy link
Contributor

markthethomas commented Jan 12, 2017 via email

@drewpc drewpc closed this as completed Jan 15, 2017
@drewpc drewpc reopened this Jan 15, 2017
@drewpc
Copy link
Collaborator

drewpc commented Jan 15, 2017

Sorry for closing, I didn't realize this was moving to camelCase and dash-delimited for both sets of configs. Open again!

@mlolson
Copy link
Contributor

mlolson commented Jun 15, 2017

@markthethomas Any update on this? Mind if I take it?

@markthethomas
Copy link
Contributor

markthethomas commented Jun 15, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New functionality.
Projects
None yet
Development

No branches or pull requests

5 participants