-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support dash-delimited options in .reactserverrc
#783
Comments
* Add cli option for webpack-config * Add more doc * Doc edits * Update documentation based off pr feedback
@gigabo I can take this on if it's still a thing, looking to help out where I can w/ the project 👍 |
@markthethomas Awesome! This will make the UI more consistent / less confusing. Thanks for taking it on! |
👍💯
On Mon, Jan 9, 2017 at 2:08 PM Bo Borgerson ***@***.***> wrote:
@markthethomas <https://github.com/markthethomas> Awesome! This will make
the UI more consistent / less confusing. Thanks for taking it on!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#783 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEstAZWL4S5BXdKbe-DKFPwOp7QX7Lbmks5rQq_kgaJpZM4LEwFQ>
.
--
Mark Thomas
- - -
@markthethomas everywhere
ifelse.io
|
@gigabo I'd also be interested in helping clear up some of the docs and/or helping w/ the component API documentation, there are a few things I've run into when integrating this w/ my projects that I've yet to overcome all the way 👍 think I saw a few other issues where this came up |
@gigabo is there any general objection to bringing in deps to address things like this? was thinking of decamelize, which I think yargs already depends on and uses to address this case. jw before I commit and PR anything 👍 |
Generally, we're trying to head in the opposite direction, per #277. If, however, decamelize is already in our dependency closure, and yargs doesn't have a way to support this natively, then I don't see any harm. |
Sounds good, thanks!
On Wed, Jan 11, 2017 at 4:07 PM Douglas Wade ***@***.***> wrote:
Generally, we're trying to head in the opposite direction, per #277
<#277>. If, however,
decamelize is already in our dependency closure, and yargs doesn't have a
way to support this natively, then I don't see any harm.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#783 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEstAZgnal7c7cwnP_gk2hpvDwVX7Ipcks5rRW7MgaJpZM4LEwFQ>
.
--
Mark Thomas
- - -
@markthethomas everywhere
ifelse.io
|
Sorry for closing, I didn't realize this was moving to camelCase and dash-delimited for both sets of configs. Open again! |
@markthethomas Any update on this? Mind if I take it? |
Shoot, this totally got away from me - go ahead 👍
On Thu, Jun 15, 2017 at 3:57 PM Matt Olson ***@***.***> wrote:
@markthethomas <https://github.com/markthethomas> Any update on this?
Mind if I take it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#783 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEstATzVURvgbxleT3XaE1dUhzMcIpEdks5sEbMWgaJpZM4LEwFQ>
.
--
Mark Thomas
- - -
@markthethomas everywhere
ifelse.io
|
The CLI supports options both
--camelCase
and--dash-delimited
.The
.reactserverrc
config file only supportscamelCase
keys.We should make the config file support both also to eliminate frustrating behavior.
The text was updated successfully, but these errors were encountered: