Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect webpack configuration guidelines #790

Closed
kaytcat opened this issue Dec 15, 2016 · 2 comments
Closed

Incorrect webpack configuration guidelines #790

kaytcat opened this issue Dec 15, 2016 · 2 comments

Comments

@kaytcat
Copy link
Contributor

kaytcat commented Dec 15, 2016

The documentation for adding webpack configuration (https://github.com/redfin/react-server/blob/master/docs/guides/react-server-cli.md#webpack-options) is using camel case for defining the webpackConfig option which makes sense since the rest of the options are camel cased. However, I've found the option only works when written as "webpack-config".

I think maybe the code could be updated to use all camel cased options or at least the guide could reflect the correct options.

@feychou
Copy link
Contributor

feychou commented Dec 15, 2016

Related a23199e

@gigabo
Copy link
Contributor

gigabo commented Dec 15, 2016

Ugh. Thanks for reporting @kaytcat.

#783 would resolve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants