Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPSTREAM] Replace old model-mesh manifests to new manifests #815 #387

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

Jooho
Copy link

@Jooho Jooho commented Jun 15, 2023

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • For commits that came from upstream, [UPSTREAM] has been prepended to the commit message
  • JIRA link(s): https://issues.redhat.com/browse/RHODS-8375
  • The Jira story is acked
  • An entry has been added to the latest build document in Build Announcements Folder.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious)

This PR needs to be merged with this odh-deployer PR

Test Scenarios:

  • Fresh Installation
  • Upgrade

Fresh Installation

git clone [email protected]:data-hub/olminstall.git
cd olminstall
./setup.sh -t operator -i quay.io/jooholee/rhods-operator-live-catalog:1.29.0-mm-change

# Clean up
./clean.sh -t operator 

Upgrade

./setup.sh -t operator -i quay.io/jooholee/rhods-operator-live-catalog:1.27.0-release

# Wait until all components are deployed.
# upgrade
oc patch  catalogsource rhods-catalog-dev -p '{"spec": {"image": "quay.io/jooholee/rhods-operator-live-catalog:1.29.0-mm-change"}}' --type merge

oc get kfdef rhods-model-mesh -n redhat-ods-applications -o yaml
...
 applications:
  - kustomizeConfig:
      parameters:
      - name: odh-mm-rest-proxy
        value: ${RELATED_IMAGE_ODH_MM_REST_PROXY_IMAGE}
      - name: odh-modelmesh-runtime-adapter
        value: ${RELATED_IMAGE_ODH_MODELMESH_RUNTIME_ADAPTER_IMAGE}
      - name: odh-modelmesh
        value: ${RELATED_IMAGE_ODH_MODELMESH_IMAGE}
      - name: odh-modelmesh-controller
        value: ${RELATED_IMAGE_ODH_MODELMESH_CONTROLLER_IMAGE}
      - name: odh-model-controller
        value: ${RELATED_IMAGE_ODH_MODEL_CONTROLLER_IMAGE}
      - name: monitoring-namespace
        value: redhat-ods-monitoring
      repoRef:
        name: manifests
        path: model-mesh
    name: model-mesh
...

Copy link
Member

@VedantMahabaleshwarkar VedantMahabaleshwarkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Jooho Jooho merged commit 4ffebbd into red-hat-data-services:master Jun 16, 2023
@Jooho Jooho mentioned this pull request Jun 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants