-
Notifications
You must be signed in to change notification settings - Fork 211
Replace old model-mesh manifests to new manifests #815
Replace old model-mesh manifests to new manifests #815
Conversation
1d28852
to
e6259e6
Compare
/retest |
/retest |
1 similar comment
/retest |
Signed-off-by: jooho <[email protected]>
/retest |
/retest-required |
1 similar comment
/retest-required |
/retest |
@anishasthana Finally this passed all tests!. Could you please review this PR? |
/lgtm Well done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as two component owners have approved/lgtm'd it.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anishasthana, danielezonca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Follow-up minor issue relared to serving runtimes: https://github.com/opendatahub-io/odh-manifests/issues/809 Inconsistent usage of kustomization.images refs vs parameter (ovms). |
another error that came up previous to this master-level change, fixed with the changes in this PR / master:
|
…tahub-io#815 Signed-off-by: jooho <[email protected]>
[UPSTREAM] Replace old model-mesh manifests to new manifests opendatahub-io#815
@@ -39,7 +50,7 @@ Following are the steps to install Model Mesh as a part of OpenDataHub install: | |||
|
|||
1. Install the OpenDataHub operator | |||
2. Create a KfDef that includes the model-mesh component with the odh-model-controller overlay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with the odh-model-controller overlay.
should this text be removed since the overlay got removed? @Jooho
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Catcher. Right, this should be deleted.
Description
The old model mesh manifest was independent of the upstream model mesh, so when the upstream model mesh manifest changed, it was very difficult to update the opendatahub manifest to follow its history. So the new manifest uses the upstream manifest as much as possible via an overlay, with only minor changes.
Inside this folder, there are now two main component manifest folders:
odh-model-controller
,odh-modelmesh-controller
Each component utilized the manifest from the main repository as much as possible and used overlay or params.env for other components.
How Has This Been Tested?
The way how to use the
model-mesh
manifests is the same as before so you can test this with the kfdef that we used.Merge criteria:
ISSUE: https://issues.redhat.com/browse/RHODS-8375