-
-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[scoped on PHP 7.0] bin/rector run with extracted phpstan #6371
Conversation
composer.json
Outdated
@@ -96,7 +96,8 @@ | |||
}, | |||
"files": [ | |||
"src/functions/node_helper.php", | |||
"src/constants.php" | |||
"src/constants.php", | |||
"vendor/phpstan/phpstan-extracted/vendor/autoload.php" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will load phpstan's autoload and its own vendor/nikic/php-parser
.
This package is in the same version, so Rector's preload.php
would conflict with same classes.
That's why its nulled bellow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line must be added via config CLI command: composer config ...
In: .github/workflows/build_scoped_rector_php70.yaml
Now it breaks other builds
- run: rm -rf vendor/phpstan/phpstan/phpstan.phar | ||
|
||
# THIS MUST WORK | ||
- run: bin/rector downgrade-paths |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samsonasik Here is a prototype of PHP 7.0 build that doesn't use on |
As I said, your job might be easier if you contribute the PHP 7.0 downgrading to PHPStan compiling itself. |
Might do later, but first I need to Rector work on PHP 7.0. Now it can handle PHP 7.1 tops. This is just theory :) You can add Rector to your build workflow later based on our downgrade build. Should be easy. |
@TomasVotruba thank you 👍 |
3cf89b0
to
9907c78
Compare
9907c78
to
528d4a6
Compare
"rector/rector-installer": "^0.10.1", | ||
"rector/extension-installer": "^0.10.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sabbelasichon Btw, I flipped the name to extension-installer
, as rector-<x>
name is used for framework-specific sets. Like rector-nette
, rector-symfony
etc.
This should make also clear it does not install rector, but extensions.
rectorphp/rector-src@203651a [CodeQuality] Skip else indirect return on SimplifyIfReturnBoolRector (#6371)
No description provided.