composer: allow symfony/service-contracts that allow PHP 8

[TomasVotruba]

We're trying to install src to downgrade it, but this packages blocks it on PHP 8:

• https://packagist.org/packages/symfony/service-contracts#v1.1.8

The very next patch version luckily allows PHP 8 :)

• https://packagist.org/packages/symfony/service-contracts#v1.1.9

[TomasVotruba]

Btw, what do you this package for? I never saw it used only by Symfony internally

[ondrejmirtes]

Hi, I thought that you're using the already prefixed phpstan/phpstan PHAR to bundle it with rector-prefixed? What do you need phpstan-src for?

The package is mentioned in composer.json only to lock it to a version that still supports 7.1.

[TomasVotruba]

What do you need phpstan-src for?

To downgrade it to PHP 7.0 and bellow :)

The package is mentioned in composer.json only to lock it to a version that still supports 7.1.

I guess composer config platform version is better for that.
The proposed version supports both PHP 7.1 and 8.0.

[ondrejmirtes]

Well you should use the contents of phpstan.phar in phpstan/phpstan as the base to downgrade further :) Is there any problem with that?

[TomasVotruba]

That's the other way. You mean with box.phar? I haven't tried that yet

[ondrejmirtes]

Yes, you can extract it with box.phar.

Alternatively, you can contribute the downgrading to PHPStan compiler process itself, so that even PHPStan users can take advantage of that :)

[TomasVotruba]

I think it's chicken egg problem :)
PHP 8 native support in phpstan-src would be the first step for that. I plan to bump core to PHP 8.

We'll try the box.phar approach, just have to figure out the shared php-parser code autoloading.

[ondrejmirtes]

I don't understand - I develop phpstan-src on PHP 8 without any tricks. See the CI.

[TomasVotruba]

Yea, core repository and dependency behaves differently. Now it's not possible to install phpstan-src as dependency on PHP 8 due to this blocker.

[TomasVotruba]

I'm trying to include phpstan.phar unpacked here:
rectorphp/rector#6371

It would be great to somehow resolve including of preload.php for same php-parser in the start.

[ondrejmirtes]

Yes, that's not supported by design, the package isn't published to Packagist, everyone is supposed to use phpstan/phpstan.