Refactor is_a

[samsonasik]

Fixes #5906

[samsonasik]

@ondrejmirtes this is_a change 5ac198c seems cause error in test:

1) Rector\Tests\NetteToSymfony\Rector\Interface_\DeleteFactoryInterfaceRector\DeleteFactoryInterfaceFileSystemRectorTest::test with data set #0 (Symplify\SmartFileSystem\SmartFileInfo Object (...))
61
Failed asserting that false is true.

@TomasVotruba PHPStan notice seems unrelated as i tried in local and got same error with or without this change:

vendor/bin/phpstan analyse --ansi --error-format symplify packages/BetterPhpDocParser/ValueObject/PhpDocNode/JMS/SerializerTypeTagValueNode.php
Note: Using configuration file /Users/samsonasik/www/rector/phpstan.neon.
PHP Fatal error:  Class Rector\BetterPhpDocParser\ValueObject\PhpDocNode\JMS\SerializerTypeTagValueNode contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (PHPStan\PhpDocParser\Ast\Node::hasAttribute) in /Users/samsonasik/www/rector/packages/BetterPhpDocParser/ValueObject/PhpDocNode/JMS/SerializerTypeTagValueNode.php on line 13
Fatal error: Class Rector\BetterPhpDocParser\ValueObject\PhpDocNode\JMS\SerializerTypeTagValueNode contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (PHPStan\PhpDocParser\Ast\Node::hasAttribute) in /Users/samsonasik/www/rector/packages/BetterPhpDocParser/ValueObject/PhpDocNode/JMS/SerializerTypeTagValueNode.php on line 13

[TomasVotruba]

@samsonasik I need to merge this #5841 first

[samsonasik]

@TomasVotruba thank you 👍

[samsonasik]

@ondrejmirtes I got the patch about failing unit test, the UnionType need to check against ShortenedObjectType to make $returnType re-assigned with new ObjectType($returnType->getFullyQualifiedName()) --> f4ee4c4

[samsonasik]

test error start from change 79f8698

-        return is_a($currentType->getClassName(), $newType->getClassName(), true);
+        return $newType->isSuperTypeOf($currentType)->yes();

[samsonasik]

try check one by one, it seems caused by 2bc0a98

[samsonasik]

somehow, it fixed with return early on yes() check instead of no() and continue:

-                if (! is_a($type->getClassName(), $countableObjectType->getClassName(), true)) {
-                     continue;
+                 if ($countableObjectType->isSuperTypeOf($type)->yes()) {
+                     return true;
+                 }

[TomasVotruba]

The check work without this wraparound, as in other places

[samsonasik]

without this check, it got error in test like in my previous comment #5907 (comment)

[samsonasik]

@ondrejmirtes I tried update other places, but got errors like in my previous comments, I rollback to only apply what you suggested in #5906 .

[TomasVotruba]

I'll look into this

[TomasVotruba]

Thank you 👍