[PhpDocParser] Make use of native attributes #5841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
changed the title
TomasVotruba
commented
Mar 14, 2021
TomasVotruba
force-pushed
the
phpdoc-with-attributes-2
branch
8 times, most recently
from
4ba6f14 to
241eee0
Compare
TomasVotruba
force-pushed
the
phpdoc-with-attributes-2
branch
13 times, most recently
from
4d290f3 to
e7b516f
Compare
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
phpdoc-with-attributes-2
branch
4 times, most recently
from
30ddfb9 to
7f91c3e
Compare
TomasVotruba
force-pushed
the
phpdoc-with-attributes-2
branch
2 times, most recently
from
6203015 to
0e591d5
Compare
Merged
TomasVotruba
force-pushed
the
phpdoc-with-attributes-2
branch
from
0e591d5 to
23241ed
Compare
TomasVotruba
force-pushed
the
phpdoc-with-attributes-2
branch
from
d6fcba7 to
207326d
Compare
|
There is a BC break in phpstan/phpdoc-parser@b451b2f Trying to figure out the fix now |
|
What BC break? |
samsonasik
reviewed
Mar 19, 2021
|
@ondrejmirtes Format preserving with spaces. We're trying to detect old spaces from old code with regular expression and it now fails, because it's one less token somewhere.
|
TomasVotruba
force-pushed
the
phpdoc-with-attributes-2
branch
3 times, most recently
from
bf07a9e to
44a89fe
Compare
TomasVotruba
force-pushed
the
phpdoc-with-attributes-2
branch
2 times, most recently
from
03e9eff to
b38f56f
Compare
TomasVotruba
force-pushed
the
phpdoc-with-attributes-2
branch
from
330e0bc to
9c108ef
Compare
This was referenced Mar 20, 2021
TomasVotruba
added a commit
that referenced
this pull request
Apr 22, 2024
rectorphp/rector-src@6eac87d Ignore phpdoc type in RecastingRemovalRector (#5841)
TomasVotruba
added a commit
that referenced
this pull request
Apr 22, 2024
rectorphp/rector-src@6eac87d Ignore phpdoc type in RecastingRemovalRector (#5841)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waits on phpstan/phpdoc-parser#57 to be merged.
Then it's ready to 🚀