[DeadDocBlock] Skip RemoveUselessParamTagRector on Generic Type #5677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Failing Test for RemoveUselessParamTagRector Based on https://getrector.org/demo/fa28aacc-8081-4f41-8c64-db0e680434e3
|
/cc @OskarStark |
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
|
Thank you 👍 |
|
Just asking to plan the way to go in my project. Can I expect a release soon or in a few days? |
|
Somewhere between 1-5 days, depens how #5665 goes. It has a priority now :) |
|
Thanks 👍 |
TomasVotruba
added a commit
that referenced
this pull request
Mar 2, 2024
rectorphp/rector-src@dea2e16 [PHP 8.0] Fix case insenstive false positive replacement for str_ends_with (#5677)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5676