Make use of static reflection from PHPStan

[TomasVotruba]

Closes #3490

Now Rector autoloads all the code that analyses. That means all your projects has to be loaded with composer, custom autoload or included. That can lead to side-effects like these:

// in Rector
include __DIR__ . '/some_file.php';

// some_file.php
mysql_connect('...');

↓

Fatal error: canont connect to mysql

The only way to avoid this is to use static reflections. That means the code is parsed, so Rector knows about mysql_connect function call, but it is not included and does not produce side effects. Win win 🎉

---

Todo

• break rename test without autoload
• replace ClassExistenceStaticHelper::doesClassLikeExists() with ReflectionProvider->hasClass()
• replace class_exists() with ReflectionProvider->hasClass()
• fix AnnotationReader to work with native reflections

SourceLocatorFactory

• add custom phpstan.neon for Rector internalls - here 9071f1b#diff-d4ecbf7aff4875121457666bba3371091eb5009fda360c3c51068e135075bf7c
• add custom source locator to custom phpstan.neon config - Taking advantage of static reflection #3490 (comment)
• add custom source locator to Rector too, for dynamic per TestCase source adding
• pass parsed input sources to Rector\NodeTypeResolver\Reflection\BetterReflection\SourceLocatorProvider\DynamicSourceLocator, e.g. vendor/bin/rector process <src>

Tests

• make test pass again
• make test pass without autoload
• replace is_a(), instanceof, $objectType->hasMethod(), $objectType->hasProperty() with ClassReflection API

[ondrejmirtes]

It depends on how the ReflectionProvider instance looks like in Rector. In PHPStan by default it's a chain of various ReflectionProvider implementations. In layman's terms, if a class is reachable through a correctly configured Composer autoloader, a runtime reflection will be used. Otherwise static reflection is used.

[TomasVotruba]

Rector is using the same ReflectionProvider service, and adding files and directories from rector.php and paths arguments from vendor/bin/rector process src to SourceLocator.

[mpdude]

(How) can I run Rector with a version of PHPStan that is not packed up as a Phar?

[ondrejmirtes]

Nope, PHPStan is only distributed as PHAR. What are your needs?

[mpdude]

Debug into Rector, see when/how it uses ReflectionProvider and subclasses, being able to tinker around with that code to understand if/when/how/why runtime reflection comes into play.

(To understand when/why scoping Rector is needed, and to understand when/why Rector needs to run with the same PHP version as the project it analyzes.)

[ondrejmirtes]

Xdebug works even with PHARs.

[mpdude]

... but changing code (commenting out things etc) does not.

[mpdude]

But I'll take this as "there is no easy way to install a non-Phar source version of PHPStan" and deal with it 😉

[ondrejmirtes]

You can always clone phpstan-src alongside a project and run plain PHPStan using ../phpstan-src/phpstan analyse ... on a codebase, but not in combination with Rector.