[DeadCode] Add RemoveDeadConditionAboveReturnRector #5194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
changed the title
Comment on lines
+9
to
+13
| if (1 === 1) { | ||
| return 'yes'; | ||
| } | ||
|
|
||
| return 'yes'; |
There was a problem hiding this comment.
I see. This case should be covered too, right?
-if (1 === 'hey') {
- return 'yes';
-}
return 'yes';There was a problem hiding this comment.
the check is not in the cond of if, but on its stmt, so that's already covered.
There was a problem hiding this comment.
I added new fixture 08a197f for different cond
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
|
Thank you 👍 |
TomasVotruba
added a commit
that referenced
this pull request
Oct 23, 2023
rectorphp/rector-src@3e505e5 add fixture for only importNames() without removeUnusedIMpotrs() (#5194)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4925