Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DeadCode] Remove dead condition above return anyway #4925

Closed
TomasVotruba opened this issue Dec 20, 2020 · 0 comments · Fixed by #5194
Closed

[DeadCode] Remove dead condition above return anyway #4925

TomasVotruba opened this issue Dec 20, 2020 · 0 comments · Fixed by #5194
Labels
feature

Comments

@TomasVotruba
Copy link
Member 

-        if ($node instanceof Expr) {
-            return null;
-        }

        return null;
@TomasVotruba TomasVotruba changed the title [DeadCode] Remove return anyway [DeadCode] Remove dead condition above return anyway Dec 20, 2020
samsonasik added a commit that referenced this issue Jan 15, 2021
@samsonasik
[DeadCode][WIP] Fixes #4925 Add RemoveDeadConditionAboveReturnRector
2c1c6eb
@samsonasik samsonasik mentioned this issue Jan 15, 2021
Merged
TomasVotruba pushed a commit that referenced this issue Jan 15, 2021
@samsonasik
[DeadCode] Add RemoveDeadConditionAboveReturnRector (#5194)
ac677c9 
* [DeadCode][WIP] Fixes #4925 Add RemoveDeadConditionAboveReturnRector

* apply

* functional

* skip prev not if

* skip prev has elseif

* skip prev has else

* skip prev has multi stmt

* skip prev not return

* skip prev different return

* cs fix

* class name fixture fix

* skip prev empty stmt

* remove prev empty stmt

* add different cond
TomasVotruba added a commit that referenced this issue Sep 30, 2023
@TomasVotruba
Updated Rector to commit 0c0e5eeb4fd337d98f27224d0b46bfd310405dfd
d7242c6 
rectorphp/rector-src@0c0e5ee AddParamTypeBasedOnPHPUnitDataProviderRector: Enhance existing rule to handle PHPUnit 10+ DataProvider Attribute (#4925)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DeadCode] Add RemoveDeadConditionAboveReturnRector rectorphp/rector
1 participant
@TomasVotruba