Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Symfony 5.2] Add BinaryFileResponseCreateToNewInstanceRector #4846

Merged
merged 4 commits into from
Dec 11, 2020
Merged

[Symfony 5.2] Add BinaryFileResponseCreateToNewInstanceRector #4846

merged 4 commits into from
Dec 11, 2020

Conversation

simivar
Copy link
Contributor

@simivar simivar commented Dec 10, 2020

Part of #4824

@simivar simivar requested a review from TomasVotruba December 10, 2020 19:03
@TomasVotruba
Copy link
Member

Better move it to "Symfony" namespace

@simivar
Copy link
Contributor Author

simivar commented Dec 10, 2020

Don't you think it will be a little crowded there as we want to provide Rectors for 5.0 -> 5.1, 5.1 -> 5.2, and, possibly in the future, more of such migrations? Thanks to a separate namespace it will be as well easy to say which Rector do the changes for which version and what is still lacking in the migration.

@TomasVotruba
Copy link
Member

TomasVotruba commented Dec 10, 2020

It might. But we should not have 2 standards here, now it looks pretty unclear where to put next Symfony rule.

It might be worth to have major as a split here, rather then 20 directories per minor.

  • Symfony2
  • Symfony3
  • Symfony4
  • Symfony5

This PR should handle the split, or add a new rule. Not both.

@simivar
Copy link
Contributor Author

simivar commented Dec 10, 2020

Should I change the namespace to Symfony5 now and in separate MR split the current Symfony to their respective ones?

@TomasVotruba
Copy link
Member

The current namespace is only Symfony. Please use it, then handle renaming/splitting in next PR

@TomasVotruba
Copy link
Member

Thank you 👍

@TomasVotruba TomasVotruba merged commit 668753b into rectorphp:master Dec 11, 2020
@simivar simivar deleted the feature/symfony52-httpfoundation-binaryfileresponse branch December 11, 2020 10:37
TomasVotruba added a commit that referenced this pull request Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants