[Symfony 5.2] Add BinaryFileResponseCreateToNewInstanceRector (#4846)

config/set/symfony52.php

@@ -6,6 +6,7 @@
 use Rector\Renaming\Rector\MethodCall\RenameMethodRector;
 use Rector\Renaming\ValueObject\MethodCallRename;
 use Rector\Renaming\ValueObject\RenameClassConstant;
+use Rector\Symfony\Rector\StaticCall\BinaryFileResponseCreateToNewInstanceRector;
 use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
 use Symplify\SymfonyPhpConfig\ValueObjectInliner;
 
@@ -16,6 +17,9 @@
 
     $services = $containerConfigurator->services();
 
+    # https://github.com/symfony/symfony/blob/5.x/UPGRADE-5.2.md#httpfoundation
+    $services->set(BinaryFileResponseCreateToNewInstanceRector::class);
+
     # https://github.com/symfony/symfony/blob/5.x/UPGRADE-5.2.md#mime
     $services->set(RenameMethodRector::class)
         ->call('configure', [[

rules/symfony/src/Rector/StaticCall/BinaryFileResponseCreateToNewInstanceRector.php

@@ -0,0 +1,84 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Symfony\Rector\StaticCall;
+
+use PhpParser\Node;
+use PhpParser\Node\Expr\New_;
+use PhpParser\Node\Expr\StaticCall;
+use PhpParser\Node\Name;
+use Rector\Core\Rector\AbstractRector;
+use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
+use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
+
+/**
+ * @see https://github.com/symfony/symfony/blob/5.x/UPGRADE-5.2.md#httpfoundation
+ * @see \Rector\Symfony\Tests\Rector\StaticCall\BinaryFileResponseCreateToNewInstanceRector\BinaryFileResponseCreateToNewInstanceRectorTest
+ */
+final class BinaryFileResponseCreateToNewInstanceRector extends AbstractRector
+{
+    public function getRuleDefinition(): RuleDefinition
+    {
+        return new RuleDefinition('Change deprecated BinaryFileResponse::create() to use __construct() instead', [
+            new CodeSample(
+                <<<'CODE_SAMPLE'
+use Symfony\Component\HttpFoundation;
+
+class SomeClass
+{
+    public function run()
+    {
+        $binaryFile = BinaryFileResponse::create();
+    }
+}
+CODE_SAMPLE
+                ,
+                <<<'CODE_SAMPLE'
+use Symfony\Component\HttpFoundation;
+
+class SomeClass
+{
+    public function run()
+    {
+        $binaryFile = new BinaryFileResponse(null);
+    }
+}
+CODE_SAMPLE
+            ),
+        ]);
+    }
+
+    /**
+     * @return string[]
+     */
+    public function getNodeTypes(): array
+    {
+        return [StaticCall::class];
+    }
+
+    /**
+     * @param StaticCall $node
+     */
+    public function refactor(Node $node): ?Node
+    {
+        if (! $node->class instanceof Name) {
+            return null;
+        }
+
+        if (! $this->isName($node->class, 'Symfony\Component\HttpFoundation\BinaryFileResponse')) {
+            return null;
+        }
+
+        if (! $this->isName($node->name, 'create')) {
+            return null;
+        }
+
+        $args = $node->args;
+        if ([] === $args) {
+            $args[] = $this->createArg($this->createNull());
+        }
+
+        return new New_($node->class, $args);
+    }
+}

rules/symfony/tests/Rector/StaticCall/BinaryFileResponseCreateToNewInstanceRector/BinaryFileResponseCreateToNewInstanceRectorTest.php

@@ -0,0 +1,31 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Symfony\Tests\Rector\StaticCall\BinaryFileResponseCreateToNewInstanceRector;
+
+use Iterator;
+use Rector\Symfony\Rector\StaticCall\BinaryFileResponseCreateToNewInstanceRector;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+use Symplify\SmartFileSystem\SmartFileInfo;
+
+final class BinaryFileResponseCreateToNewInstanceRectorTest extends AbstractRectorTestCase
+{
+    /**
+     * @dataProvider provideData()
+     */
+    public function test(SmartFileInfo $fileInfo): void
+    {
+        $this->doTestFileInfo($fileInfo);
+    }
+
+    public function provideData(): Iterator
+    {
+        return $this->yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    protected function getRectorClass(): string
+    {
+        return BinaryFileResponseCreateToNewInstanceRector::class;
+    }
+}

rules/symfony/tests/Rector/StaticCall/BinaryFileResponseCreateToNewInstanceRector/Fixture/create_with_argument.php.inc

@@ -0,0 +1,31 @@
+<?php
+
+namespace Rector\Symfony\Tests\Rector\StaticCall\BinaryFileResponseCreateToNewInstanceRector\Fixture;
+
+use Symfony\Component\HttpFoundation\BinaryFileResponse;
+
+class CreateWithArgument
+{
+    public function action()
+    {
+        return BinaryFileResponse::create('some_file_path.txt');
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Symfony\Tests\Rector\StaticCall\BinaryFileResponseCreateToNewInstanceRector\Fixture;
+
+use Symfony\Component\HttpFoundation\BinaryFileResponse;
+
+class CreateWithArgument
+{
+    public function action()
+    {
+        return new BinaryFileResponse('some_file_path.txt');
+    }
+}
+
+?>

rules/symfony/tests/Rector/StaticCall/BinaryFileResponseCreateToNewInstanceRector/Fixture/create_without_arguments.php.inc

@@ -0,0 +1,31 @@
+<?php
+
+namespace Rector\Symfony\Tests\Rector\StaticCall\BinaryFileResponseCreateToNewInstanceRector\Fixture;
+
+use Symfony\Component\HttpFoundation\BinaryFileResponse;
+
+class CreateWithoutArguments
+{
+    public function action()
+    {
+        $binaryFileResponse = BinaryFileResponse::create();
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Symfony\Tests\Rector\StaticCall\BinaryFileResponseCreateToNewInstanceRector\Fixture;
+
+use Symfony\Component\HttpFoundation\BinaryFileResponse;
+
+class CreateWithoutArguments
+{
+    public function action()
+    {
+        $binaryFileResponse = new BinaryFileResponse(null);
+    }
+}
+
+?>