PHAR alternative - build PrefixedRector

[mssimi]

It is not complete, but already got working proof of concept:)

I'm taking a little break now that regular expressions killing me:)

What is missing:

1. Get tests working(php.inc is not prefixed)
2. Fix error found by tests
3. Git push build dir somewhere to github.

[TomasVotruba]

Great job 👍 I can handle regulars, if that's pain for you.

It looks like wrong screenshot, since it replaces classes.

[mssimi]

It is not wrong screen I wanted to make simple preview it is already somehow working:D Notice I run that under build directory.

[mssimi]

As of regular expressions I had to use perl instead sed as I was unable to get that working with sed.

[TomasVotruba]

I see. Yesterday we talked about NamespaceReplacer and now you're using ClassReplacer, it does different thing :).

NamespacePrefixer is the goal and the screen doesn't do it.

[TomasVotruba]

PHP Scoper should be a dependnecy in composer.json

[mssimi]

In docs it is not recommended.

[TomasVotruba]

Docs is not a dog, nor God :)
Still, should be dependency in composer.json. Without that we have to maintain phar manually.

What advantages do you see?

[mssimi]

Conflict avoidance.

[theofidry]

bamarni/composer-bin-plugin or phive can both help out there (see this article)[https://medium.com/@tfidry/managing-your-dependencies-in-php-321d584441ab]. But I advise against relying on committing the PHAR:

• it's really heavy on the Git history
• it's much harder to cherry-pick a branch to try a bugfix or something

If you want to go that way nonetheless, I recommend to mark the public key as a binary file as well in .gitattributes

[TomasVotruba]

I just tried bamarni/composer-bin-plugin but it cannot work due to php-parser 3/4 conflict.

[TomasVotruba]

So phar seems as the best option for the time being. It doesn't evolve much and the php-parser 4 + better reflectoin is main blocker there, so missing update-ability won't be such a problem.

[mssimi]

This pull request is not about NamespacePrefixerRector this is about PHAR alternative. I made working prefixed rector w/o creating custom Rector for that.

[TomasVotruba]

Oh, the image it not for the PR you provided, but for the tool it generated. I get it now

[theofidry]

@mssimi what about doing that in PHP-Scoper directly? I think it would be more interesting to have it able to scope a Symfony application out of the box rather than requiring every user to meddle with regexes

[TomasVotruba]

@theofidry

@mssimi what about doing that in PHP-Scoper directly? I think it would be more interesting to have it able to scope a Symfony application out of the box rather than requiring every user to meddle with regexes

What exactly do you mean by this?

[theofidry]

I mean instead of trying to modify the YAML service files like that, a support could be added to PHP-Scoper to be able to change the YAML files directly

[TomasVotruba]

I see, that's more clear, thanks. I can look on that later.

At the moment I'd like skip Rector\* classes in prefixing, so this can be removed: https://github.com/rectorphp/rector/pull/449/files#diff-b5d0ee8c97c7abd7e3fa29b9a27d1780R69

How to do that?

I found only Whitelist: https://github.com/humbug/php-scoper#whitelist:

return [
    'whitelist' => [
        'PHPUnit\Framework\TestCase',
    ],
];

but it seems only accepts fully class names only. We need:

return [
    'whitelist' => [
        'Rector\*',
    ],
];

[theofidry]

I found only Whitelist: https://github.com/humbug/php-scoper#whitelist, but it seems only accepts fully class names only

Yes for now. We need to find an easier way to whitelist stuff (see humbug/php-scoper#192 (comment)) and extend it to constants and functions as well (potentially way more tricky).

[TomasVotruba]

How to do it now?

I used RobotLoader for now.

[TomasVotruba]

Continues in #465

@mssimi Thanks for you work, I'm using ~80 % of it in following PR!
Slowly but surelly we're getting there