PHAR improvements

[mssimi]

Related to #319

Simplified and greatly improved performance of PHAR building script by using rsync.
Add composer script to build PHAR.
You can now ignore PHAR files in .pharignore.
Included an example for prefixing vendors using rector(performance is bad here so example is just for small folder).

Atm there is problem with autowring in PHAR as Symfony uses glob and it is not supported by PHAR.
At least this class will have to be re-implemented. I may add test for it later.

[TomasVotruba]

For reasons we've talked about and WTF like #319 (comment)
I'd recommend to use nested directory for build, e.g. common build, so file in build/rector.phar would fail on missing vendor/autoload.php.

[mssimi]

And what about bin/rector.phar?

[TomasVotruba]

In /bin only bin files should be. build is for the extra generated stuff

Don't worry, it will be usable as vendor/bin/rector.phar in the end.

[TomasVotruba]

Very creative use of Rector, like it 👍

Love the param! :)
There could be dynamic Rector (via RectorProvider), that would replace every namespace node with prefix.

[mssimi]

Every except specified would be even better:) We don't need to prefix Rector itself.

[TomasVotruba]

I see :) That would require new Rector, probably NamespacePrefixerRector

services:
    Rector\Rector\Dynamic\NamespaceReplacerRector:
        !Rector: Prefixed # all but "Rector" prefix by "Prefixed"

What do you need to know from me to write it?

[mssimi]

I will know that, after I try it:) But I feel like performance is bigger issue here, can we somehow speed it up?

[TomasVotruba]

First things first. When PHAR is done, we can improve performance.

Doing both at same time improved neither of both, tried for you :D

[carusogabriel]

I'm with Tomas here. Let's first fix this PHAR issue, than we can join forces together and make Rector as fast as we can 💪

[mssimi]

Added test for GlobResource. I could use some help here.

[mssimi]

realpath() also seems buggy in PHAR.

[TomasVotruba]

@edobarnas Here it's needed to override getContainerLoader() in AppKernel with own PharAwaretGlobFileLoader class:

final class RectorKernel extends Kernel
{

    /**
     * @param ContainerInterface|ContainerBuilder $container
     */
    protected function getContainerLoader(ContainerInterface $container): DelegatingLoader
    {
        $kernelFileLocator = new FileLocator($this);

        $loaderResolver = new LoaderResolver([
            // @todo - create this clsas
            return PharAwareGlobFileLoader($container, $kernelFileLocator));
            // ...
        ]);

        return new DelegatingLoader($loaderResolver);
    }

}

As done in here https://github.com/symplify/packagebuilder#10-do-you-need-to-merge-parameters-in-yaml-files-instead-of-override

---

PharAwareGlobFileLoader might look like this:

namespace Symfony\Component\Config\Loader\GlobFileLoader;

final class PharAwareGlobFileLoader extends GlobFileLoader
{
    protected function glob(string $pattern, bool $recursive, &$resource = null, bool $ignoreErrors = false)
    {
        // override parent glob() method logic to not-use "glob" function
    }
}

[TomasVotruba]

What do you think @mssimi ?

[mssimi]

Check GlobResource usages, I think it is not only used in loader.

[TomasVotruba]

Follow up in #449