Another attempt to add Compiler + upgrade to PHPStan 0.12 #2373

TomasVotruba · 2019-11-30T15:16:43Z

Reference Create PHAR with prefixes to avoid class and package version conflicts #177 - still needs lot of testing in the wild
Closes Doesn't work with phpstan 0.12 #2385

Inspiration

phpstan/phpstan-src@3398198

TomasVotruba · 2019-11-30T18:53:41Z

Fuckups

Symfony not phar friend for `excluded` in PSR-4 autodiscovery

Error: https://github.com/symfony/symfony/blob/c62bb82e27974ef4e389da523f0de451b6632266/src/Symfony/Component/Finder/Finder.php#L589
Might be related:
- symfony/symfony@b61c8fc
- https://github.com/symfony/symfony/blob/c62bb82e27974ef4e389da523f0de451b6632266/src/Symfony/Component/DependencyInjection/Loader/FileLoader.php#L162
Solution: not specific files, just glob paths

 services:
     Rector\TypeDeclaration\:
         resource: '../src'
         exclude:
-         	- '../src/ValueObject/SpecificFile.php'
+         	- '../src/ValueObject/*'

✔️

Symfony autodsicovery hates slash

 services:
     Rector\TypeDeclaration\:
-        resource: '../src/'
+        resource: '../src'

✔️

SHA1 cannot be verified

Error: atal error: Uncaught PharException: phar "/home/travis/build/rectorphp/rector/compiler/build/box.phar" SHA1 signature could not be verified: broken signature in /home/travis/build/rectorphp/rector/compiler/build/box.phar on line 14
Possible bug: lf/crlf line endings on push to githbu
Solution?
- download new phar first: https://github.com/humbug/box/tree/3.8.3
- .gitattibutes and keep original line-endings of the file
- THEN commit, because git will change line endings on first file appearance only

Solution remove this from .gitattributes:

-# Set default behavior, in case users don't have core.autocrlf set.
-* text=auto
-* text eol=lf

https://stackoverflow.com/questions/24763948/git-warning-lf-will-be-replaced-by-crlf

✔️

Box is not compatible with multipes bins

Before:

bin/rector
bin/autoload.php
bin/container.php

Why? To separate logic to standalone functions by file.

Now:

bin/rector

With strict typed classes written on the bottom of file and used above.

✔️

TomasVotruba · 2019-11-30T22:30:05Z

~~Fuckup post is comming :D ~~

Done: How to Box Symfony App to PHAR without Killing Yourself

gnutix · 2019-12-05T14:08:13Z

Hey @TomasVotruba ! Just discovered this PR, awesome work! :D Is it already testable somehow ? I've cd ~/dev/oss/rector && git fetch && git checkout compiler && cd compiler && bin/compile, which gave me tmp/rector.phar.

Now when I cd into our project and run php ~/dev/oss/rector/tmp/rector.phar, it gives :

PHP Fatal error:  Uncaught _HumbugBox24440d0b0be5\Nette\FileNotFoundException: File '/composer/vendor/phpstan/phpstan-symfony/extension.neon' is missing or is not readable. in phar:///home/gnutix/dev/oss/rector/tmp/rector.phar/vendor/nette/di/src/DI/Config/Loader.php:29
Stack trace:
#0 phar:///home/gnutix/dev/oss/rector/tmp/rector.phar/vendor/nette/di/src/DI/Config/Loader.php(43): _HumbugBox24440d0b0be5\Nette\DI\Config\Loader->load('/composer/vendo...', false)
#1 phar:///home/gnutix/dev/oss/rector/tmp/rector.phar/vendor/nette/di/src/DI/Compiler.php(98): _HumbugBox24440d0b0be5\Nette\DI\Config\Loader->load('/home/gnutix/de...', false)
#2 phar:///home/gnutix/dev/oss/rector/tmp/rector.phar/vendor/nette/bootstrap/src/Bootstrap/Configurator.php(186): _HumbugBox24440d0b0be5\Nette\DI\Compiler->loadConfig('/home/gnutix/de...', Object(_HumbugBox24440d0b0be5\Nette\DI\Config\Loader))
#3 phar:///home/gnutix/dev/oss/rector/tmp/rector.phar/vendor/nette/di/src/DI/ContainerLoader.php(101): _HumbugBox24440d0b0be5\Nette\Configurator->generateCon in phar:///home/gnutix/dev/oss/rector/tmp/rector.phar/vendor/nette/di/src/DI/Config/Loader.php on line 29

Fatal error: Uncaught _HumbugBox24440d0b0be5\Nette\FileNotFoundException: File '/composer/vendor/phpstan/phpstan-symfony/extension.neon' is missing or is not readable. in phar:///home/gnutix/dev/oss/rector/tmp/rector.phar/vendor/nette/di/src/DI/Config/Loader.php:29
Stack trace:
#0 phar:///home/gnutix/dev/oss/rector/tmp/rector.phar/vendor/nette/di/src/DI/Config/Loader.php(43): _HumbugBox24440d0b0be5\Nette\DI\Config\Loader->load('/composer/vendo...', false)
#1 phar:///home/gnutix/dev/oss/rector/tmp/rector.phar/vendor/nette/di/src/DI/Compiler.php(98): _HumbugBox24440d0b0be5\Nette\DI\Config\Loader->load('/home/gnutix/de...', false)
#2 phar:///home/gnutix/dev/oss/rector/tmp/rector.phar/vendor/nette/bootstrap/src/Bootstrap/Configurator.php(186): _HumbugBox24440d0b0be5\Nette\DI\Compiler->loadConfig('/home/gnutix/de...', Object(_HumbugBox24440d0b0be5\Nette\DI\Config\Loader))
#3 phar:///home/gnutix/dev/oss/rector/tmp/rector.phar/vendor/nette/di/src/DI/ContainerLoader.php(101): _HumbugBox24440d0b0be5\Nette\Configurator->generateCon in phar:///home/gnutix/dev/oss/rector/tmp/rector.phar/vendor/nette/di/src/DI/Config/Loader.php on line 29

We use PHPStan (0.11, not updated to 0.12 yet) inside a Docker container (because of PHP 7.2 clash), and we load extensions with "internal" paths (in the container) like so :

# phpstan.neon
includes:
    # These paths are within the Docker container
    - '/composer/vendor/phpstan/phpstan-symfony/extension.neon'
    - '/composer/vendor/phpstan/phpstan-phpunit/extension.neon'
    - '/composer/vendor/phpstan/phpstan-doctrine/extension.neon'
    - '/composer/vendor/phpstan/phpstan-webmozart-assert/extension.neon'
    - '/composer/vendor/jangregor/phpstan-prophecy/src/extension.neon'

I guess that's the culprit ? I can't use PHPStan 0.12 as a phar, because installation requires "nikic/php-parser": "^4.3.0" which conflicts with my project requiring "ocramius/generated-hydrator": "^2.2" (as ^3.0 only supports PHP 7.3), itself only supporting nikic/php-parser: ~2.0|~3.0. So am I stuck until I can upgrade our project to PHP 7.3+ ?

TomasVotruba · 2019-12-05T14:28:57Z

Check Travis job, there is steps to test it.
I know it fails on autoloader, but your issue should be fixed

gnutix · 2019-12-05T14:33:42Z

I'm not really sure what you mean I'm supposed to look at inside .travis.yml : it contains tons of stuff, I'm a bit lost. What do you mean by "your issue should be fixed" ? (I'm using the latest compiler branch version... is there another, more up-to-date ? This branch hasn't been merged yet, right ?)

escopecz · 2019-12-05T14:36:55Z

@gnutix check these lines: https://github.com/rectorphp/rector/pull/2373/files#diff-354f30a63fb0907d4ad57269548329e3R39-R49

To sum them up, the phar is being built automatically and the result is in the https://github.com/rectorphp/rector-prefixed repo. However, there are still issues with the final phar as Tomas noted.

gnutix · 2019-12-05T15:10:03Z

Thanks @escopecz. I've downloaded the .phar from rectorphp/rector-prefixed, same error because of PHPStan's extension within the Docker image. Should I create a separate issue about this ?

escopecz · 2019-12-05T15:37:21Z

That's odd. I'm getting ".phar://rector.phar/vendor/autoload.php", "phar://rector.phar/../../../vendor/autoload.phpHave you ran "composer update"? when I run that. Anyway, I don't think it makes sense to create new issues about features that haven't been merged to the core yet. Let's just help Tomas to get it working.

TomasVotruba · 2019-12-05T15:51:37Z

@gnutix These lines are used to build phar:

https://github.com/rectorphp/rector/pull/2373/files#diff-354f30a63fb0907d4ad57269548329e3R27-R31

Any help with fixing/testing is appreciated

TomasVotruba · 2019-12-09T14:26:34Z

Still not 100 % stable, but good enought to 🚢 it and test it in the wild.
Let's roll 👍

Thank you all for feedback and testing so far, much appreciated

mpdude · 2021-02-18T07:56:35Z

This may be a stupid question... but where can I find the off-the-shelf .phar version?

There is no hint in the README, neither here nor over at https://github.com/rectorphp/rector-prefixed, they don't even contain .phar. I also checked the GitHub "Releases" in both repos and found nothing.

Since the .phar build (at least, in this PR) was set up for Travis, and since the project seems to use GHA now... maybe it was just lost?

mpdude · 2021-02-18T08:00:47Z

Ah, the answer lies in e7f1963...

@TomasVotruba do you recall why you stopped building the .phar version?

IMO, having a .phar is the most simple and elegant solution for using a tool like Rector, since you have no interference with your project's dependencies, just grab a file and you're done.

TomasVotruba · 2021-02-18T13:19:59Z

That's a valid question 👍

Here is the release Rector 0.9 info about moving from PHAR to scoped code:
https://getrector.org/blog/2020/12/28/rector-09-released

It's important stepping stone to downgradable releases, that are easy to use and debug.

That way it will be possible to do something like this:

# php 5.6
composer require symfony/console # 2.8 is installed
composer require rector/rector # 0.9 on PHP 5.6 is installed

The oldest PHP version code-bases are the biggest hell to upgrade, so our main goal is to help them out

mpdude · 2021-02-18T19:31:44Z

Debugging phar-specific issues (guess you ment that?) for sure isn’t fun. Symfony (Console?) cannot be packed into a phar – I’ll take your word for it.

I guess it boils down to the same questions as in #5593:

Is there a requirement that the (major?) version of PHP that runs Rector must match the version of PHP currently required by the project?

Is this by design/unavoidable, or just a current bug?

Can/does/should Rector treat project code as „data“ only, or does it have to parse/load/interpret it at the runtime interpreter/language level?

I am so persistent on these particular questions because it seems to me that has great impact on how much sense it makes to invest into Docker images: In a container, at best we can keep Rector and all its dependencies fully isolated from the project (after all, that’s what it is all about). The PHP version, available extensions etc. when running Rector will almost never be in line with what the project itself uses at runtime.

That‘s all not an issue if the container runs something that will happily parse PHP 5 up to PHP 8 code as input.

But if the version of Rector (and at least also PHPStan, even in the „scoped“ variant) must match project dependencies, it‘s going to be hard to make that work with Docker images... 👨🏻‍💻

Am I making sense?

TomasVotruba · 2021-02-18T19:41:22Z

Symfony can be packed into phar, but it's a road to hell: https://tomasvotruba.com/blog/2019/12/02/how-to-box-symfony-app-to-phar-without-killing-yourself/ + Also,realpath() in phar does not work.

As for project vs Rector dependencies, they can differ: https://getrector.org/blog/2020/01/20/how-to-install-rector-despite-composer-conflicts

mpdude · 2021-02-19T13:32:59Z

Sorry, I don't understand it...

You removed the PHAR:

Here is the release Rector 0.9 info about moving from PHAR to scoped code: https://getrector.org/blog/2020/12/28/rector-09-released

... suggesting to use the scoped version and to install it using Composer, so that Composer can find versions compatible with the project's other requirements?

And then, when I asked why/how/which dependencies and/or language versions need to be in sync between the project and Rector, you answer

they can differ: https://getrector.org/blog/2020/01/20/how-to-install-rector-despite-composer-conflicts

... pointing me to a blog post that, at the bottom, announces the .phar version. I am confused 😕.

TomasVotruba · 2021-02-19T19:01:42Z

... suggesting to use the scoped version and to install it using Composer, so that Composer can find versions compatible with the project's other requirements?

Yes. Use the rector-scoped

The second post is about phar, but that's because it's older. Take it as synonymum for rector-scoped

glensc · 2021-03-26T09:18:51Z

The third point in the blog:

https://tomasvotruba.com/blog/2019/12/02/how-to-box-symfony-app-to-phar-without-killing-yourself/

it should start with the fact that you are committing the .phar to the repo, otherwise, it's confusing that you have the "spoiler" at the end of the paragraph, accidentally even mentioning a commit. 'we shipped' requires to have previous knowledge of your project and how you do the shipping.

TomasVotruba · 2021-03-27T20:59:51Z

Hi, thanks for your suggestion.

Could you edit the post content so it makes more sense?
https://github.com/tomasvotruba/tomasvotruba.com/edit/main/packages/blog/data/2019/2019-12-02-how-to-box-symfony-app-to-phar-without-killing-yourself.md

rectorphp/rector-src@03da987 Try fix stub ReflectionUnionType not found in CI php 7.2 (#2373)

TomasVotruba mentioned this pull request Nov 30, 2019

Setup the fixtures for the Symfony support humbug/php-scoper#271

Merged

28 tasks

TomasVotruba force-pushed the compiler branch 8 times, most recently from 709e2d5 to c0d4598 Compare December 1, 2019 14:01

TomasVotruba mentioned this pull request Dec 1, 2019

Create PHAR with prefixes to avoid class and package version conflicts #177

Closed

TomasVotruba force-pushed the compiler branch 6 times, most recently from 8441a32 to 3b917e6 Compare December 2, 2019 23:44

TomasVotruba mentioned this pull request Dec 2, 2019

[post] add symfony-phar TomasVotruba/tomasvotruba.com#872

Merged

TomasVotruba force-pushed the compiler branch 3 times, most recently from 278ca13 to 5463ca8 Compare December 8, 2019 13:04

fixup! Merge pull request #2409 from rectorphp/phalcon-round-2

290d0b4

TomasVotruba added 2 commits December 8, 2019 18:01

README tweaks [skip ci]

722d1d1

travis: order jobs

e3874a2

TomasVotruba force-pushed the compiler branch 3 times, most recently from 0ebcd9e to 55d8de0 Compare December 8, 2019 17:12

TomasVotruba changed the title ~~Another attempt to add Compiler~~ Another attempt to add Compiler + upgrade to PHPStan 0.12 Dec 8, 2019

TomasVotruba added 2 commits December 9, 2019 00:57

load just once experiment

bace233

bump to PHPStan 0.12

9075363

TomasVotruba force-pushed the compiler branch from 47c9eb3 to 9075363 Compare December 8, 2019 23:57

TomasVotruba added 2 commits December 9, 2019 01:12

remove fixed phpstan errors

44a9396

prevent phar repacking

7a34701

TomasVotruba mentioned this pull request Dec 9, 2019

Added default to prevent rector from breaking #2410

Merged

TomasVotruba force-pushed the compiler branch from bc8319a to ac00919 Compare December 9, 2019 13:51

various fixes

e4e73b3

TomasVotruba force-pushed the compiler branch from ac00919 to e4e73b3 Compare December 9, 2019 13:51

TomasVotruba merged commit 08eb92d into master Dec 9, 2019

TomasVotruba deleted the compiler branch December 9, 2019 14:27

This was referenced Dec 10, 2019

[Support] Running Rector on a PHP 7.2 project #2417

Closed

PHP 7.2 compatibility Ocramius/GeneratedHydrator#114

Closed

TomasVotruba added a commit that referenced this pull request May 27, 2022

Updated Rector to commit 03da987

2916f08

rectorphp/rector-src@03da987 Try fix stub ReflectionUnionType not found in CI php 7.2 (#2373)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Another attempt to add Compiler + upgrade to PHPStan 0.12 #2373

Another attempt to add Compiler + upgrade to PHPStan 0.12 #2373

TomasVotruba commented Nov 30, 2019 •

edited

Loading

TomasVotruba commented Nov 30, 2019 •

edited

Loading

TomasVotruba commented Nov 30, 2019 •

edited

Loading

gnutix commented Dec 5, 2019 •

edited

Loading

TomasVotruba commented Dec 5, 2019

gnutix commented Dec 5, 2019

escopecz commented Dec 5, 2019

gnutix commented Dec 5, 2019

escopecz commented Dec 5, 2019

TomasVotruba commented Dec 5, 2019 •

edited

Loading

TomasVotruba commented Dec 9, 2019 •

edited

Loading

mpdude commented Feb 18, 2021

mpdude commented Feb 18, 2021 •

edited

Loading

TomasVotruba commented Feb 18, 2021 •

edited

Loading

mpdude commented Feb 18, 2021

TomasVotruba commented Feb 18, 2021 •

edited

Loading

mpdude commented Feb 19, 2021

TomasVotruba commented Feb 19, 2021

glensc commented Mar 26, 2021

TomasVotruba commented Mar 27, 2021

Another attempt to add Compiler + upgrade to PHPStan 0.12 #2373

Another attempt to add Compiler + upgrade to PHPStan 0.12 #2373

Conversation

TomasVotruba commented Nov 30, 2019 • edited Loading

Inspiration

TomasVotruba commented Nov 30, 2019 • edited Loading

Fuckups

Symfony not phar friend for excluded in PSR-4 autodiscovery

Symfony autodsicovery hates slash

SHA1 cannot be verified

Box is not compatible with multipes bins

TomasVotruba commented Nov 30, 2019 • edited Loading

gnutix commented Dec 5, 2019 • edited Loading

TomasVotruba commented Dec 5, 2019

gnutix commented Dec 5, 2019

escopecz commented Dec 5, 2019

gnutix commented Dec 5, 2019

escopecz commented Dec 5, 2019

TomasVotruba commented Dec 5, 2019 • edited Loading

TomasVotruba commented Dec 9, 2019 • edited Loading

mpdude commented Feb 18, 2021

mpdude commented Feb 18, 2021 • edited Loading

TomasVotruba commented Feb 18, 2021 • edited Loading

mpdude commented Feb 18, 2021

TomasVotruba commented Feb 18, 2021 • edited Loading

mpdude commented Feb 19, 2021

TomasVotruba commented Feb 19, 2021

glensc commented Mar 26, 2021

TomasVotruba commented Mar 27, 2021

TomasVotruba commented Nov 30, 2019 •

edited

Loading

TomasVotruba commented Nov 30, 2019 •

edited

Loading

Symfony not phar friend for `excluded` in PSR-4 autodiscovery

TomasVotruba commented Nov 30, 2019 •

edited

Loading

gnutix commented Dec 5, 2019 •

edited

Loading

TomasVotruba commented Dec 5, 2019 •

edited

Loading

TomasVotruba commented Dec 9, 2019 •

edited

Loading

mpdude commented Feb 18, 2021 •

edited

Loading

TomasVotruba commented Feb 18, 2021 •

edited

Loading

TomasVotruba commented Feb 18, 2021 •

edited

Loading