Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't work with phpstan 0.12 #2385

Closed
hugochinchilla opened this issue Dec 4, 2019 · 5 comments · Fixed by #2373
Closed

Doesn't work with phpstan 0.12 #2385

hugochinchilla opened this issue Dec 4, 2019 · 5 comments · Fixed by #2373

Comments

@hugochinchilla
Copy link

A new version of phpstan has been published and rector doesn't work with it.
@TomasVotruba
Copy link
Member

There were many changes there. The best solution would be locking it in our composer.json to 0.11.19

TomasVotruba added a commit that referenced this issue Dec 4, 2019
@TomasVotruba
composer: lock phpstan to 0.11.19 due to breaking changes [clos… (#2389)
a1e3e9d 
composer: lock phpstan to 0.11.19 due to breaking changes [closes #2385]
@ondrejmirtes

This comment was marked as off-topic.

Sign in to view
@michaljusiega
Copy link

He means probably that problem:

Problem 1
    - Installation request for rector/rector ^0.5.12 -> satisfiable by rector/rector[v0.5.12].
    - rector/rector v0.5.12 requires phpstan/phpstan ^0.11.13 -> satisfiable by phpstan/phpstan[0.11.13, 0.11.14, 0.11.15, 0.11.16, 0.11.17, 0.11.18, 0.11.19] but these conflict with your requirements or minimum-stability.

@ondrejmirtes

This comment was marked as off-topic.

Sign in to view
@TomasVotruba
Copy link
Member

I see. I thought it's about BC conflicts.
I that case, composer version needs to be bumped and CI needs to pass

@TomasVotruba TomasVotruba reopened this Dec 5, 2019
@TomasVotruba TomasVotruba mentioned this issue Dec 8, 2019
Merged
TomasVotruba added a commit that referenced this issue May 29, 2022
@TomasVotruba
Updated Rector to commit 9cd69c2
9a9e896 
rectorphp/rector-src@9cd69c2 [automated] Re-Generate Nodes/Rectors Documentation (#2385)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Another attempt to add Compiler + upgrade to PHPStan 0.12 rectorphp/rector
4 participants
@ondrejmirtes @hugochinchilla @TomasVotruba @michaljusiega