Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeDeclaration] Skip once typed and else return array_map() on ReturnTypeFromStrictTypedCallRector #4312

Merged
merged 2 commits into from
Jun 21, 2023
Merged

[TypeDeclaration] Skip once typed and else return array_map() on ReturnTypeFromStrictTypedCallRector #4312

merged 2 commits into from
Jun 21, 2023

Conversation

samsonasik
Copy link
Member

Closes #4311

SelrahcD and others added 2 commits June 21, 2023 17:41
@SelrahcD
Add missing test case for native call
5f96f15 
When using a native call and returning first, here `array_map`, the `ReturnTypeFromStrictTypedCallRector` uses it directly and doesn't check that later `return` might return another type.
@samsonasik
[TypeDeclaration] Skip once typed and else return array_map() on Retu…
b9c8a49 
…rnTypeFromStrictTypedCallRector
@samsonasik samsonasik mentioned this pull request Jun 21, 2023
Closed
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 1179698 into main Jun 21, 2023
@samsonasik samsonasik deleted the close-4311 branch June 21, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonasik @SelrahcD