[TypeDeclaration] Skip once typed and else return array_map() on Retu…

…rnTypeFromStrictTypedCallRector (#4312)

* Add missing test case for native call

When using a native call and returning first, here `array_map`, the `ReturnTypeFromStrictTypedCallRector` uses it directly and doesn't check that later `return` might return another type.

* [TypeDeclaration] Skip once typed and else return array_map() on ReturnTypeFromStrictTypedCallRector

---------

Co-authored-by: SelrahcD <[email protected]>

rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictTypedCallRector/Fixture/skip_once_type_and_native_call_first.php.inc

@@ -0,0 +1,22 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictTypedCallRector\Fixture;
+
+final class SkipOnceTypeAndNativeCallFirst
+{
+    public function getData()
+    {
+        if (false) {
+            return array_map(function ($i) {
+                return $i;
+            }, []);
+        }
+
+        return $this->getString();
+    }
+
+    private function getString()
+    {
+        return '...';
+    }
+}

rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictTypedCallRector/Fixture/skip_once_type_and_native_call_second.php.inc

@@ -0,0 +1,22 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictTypedCallRector\Fixture;
+
+final class SkipOnceTypeAndNativeCallSecond
+{
+    public function getData()
+    {
+        if (false) {
+            return $this->getString();
+        }
+
+        return array_map(function ($i) {
+            return $i;
+        }, []);
+    }
+
+    private function getString()
+    {
+        return '...';
+    }
+}

rules/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictTypedCallRector.php

@@ -218,7 +218,7 @@ private function findCurrentScopeReturns(ClassMethod|Function_|Closure $node): a
         $this->traverseNodesWithCallable($node->stmts, static function (Node $node) use (&$currentScopeReturns): ?int {
             // skip scope nesting
             if ($node instanceof FunctionLike) {
-                return NodeTraverser::STOP_TRAVERSAL;
+                return NodeTraverser::DONT_TRAVERSE_CURRENT_AND_CHILDREN;
             }
 
             if (! $node instanceof Return_) {