Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test xlearn #974

Merged
merged 2 commits into from
Nov 14, 2019
Merged

test xlearn #974

merged 2 commits into from
Nov 14, 2019

Conversation

miguelgfierro
Copy link
Collaborator

@miguelgfierro miguelgfierro commented Nov 13, 2019 •
edited
Loading

Description

Related Issues

#973
#908

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@miguelgfierro miguelgfierro changed the base branch from master to staging November 13, 2019 15:51
yueguoguo
yueguoguo approved these changes Nov 14, 2019
View reviewed changes
Copy link
Collaborator

@yueguoguo yueguoguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miguelgfierro miguelgfierro merged commit 260d9ec into staging Nov 14, 2019
@miguelgfierro miguelgfierro deleted the miguel/test_xlearn branch November 14, 2019 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yueguoguo yueguoguo yueguoguo approved these changes

@gramhagen gramhagen Awaiting requested review from gramhagen gramhagen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miguelgfierro @yueguoguo