Catch import error separately for SUMModel #2077
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves the issue #2064. Because TensorFlow breaking changes make the code for SUMModel not work, so the tests relating to
SUMModel
are disabled, and import errors onSUMModel
should be separately handled, otherwise, the imports followingSUMModel
(such asImplicitCF
) will not be run.recommenders/tests/smoke/recommenders/recommender/test_deeprec_model.py
Lines 10 to 32 in 96fe3cf
Related Issues
#2064
Checklist:
git commit -s -m "your commit message"
.staging branch
AND NOT TOmain branch
.