Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bug when reading dataset with timestamp for sasrec model #2052

Merged
merged 9 commits into from
Feb 7, 2024
Merged

Fixed bug when reading dataset with timestamp for sasrec model #2052

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
57f37ea
Merge pull request #1981 from recommenders-team/staging
miguelgfierro Aug 31, 2023
2aca74f
Merge pull request #1998 from recommenders-team/staging
miguelgfierro Sep 26, 2023
305f6b6
Merge pull request #2006 from recommenders-team/staging
miguelgfierro Oct 10, 2023
b000b78
Merge pull request #2019 from recommenders-team/staging
miguelgfierro Oct 13, 2023
0d9d7c7
Merge pull request #2035 from recommenders-team/staging
miguelgfierro Dec 23, 2023
2664198
Update util.py
gazon1 Jan 5, 2024
292fdf5
Update util.py
gazon1 Jan 5, 2024
0c1933a
Update util.py
gazon1 Jan 5, 2024
7205f2a
Update util.py
miguelgfierro Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions recommenders/models/sasrec/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,13 @@ def __init__(self, **kwargs):
if self.filename:
with open(self.filename, "r") as fr:
sample = fr.readline()
ncols = sample.strip().split(self.col_sep)
ncols = len(sample.strip().split(self.col_sep))
if ncols == 3:
self.with_time = True
else:
elif ncols == 2:
self.with_time = False
else:
raise ValueError(f"3 or 2 columns must be in dataset. Given {ncols} columns")

def split(self, **kwargs):
self.filename = kwargs.get("filename", self.filename)
Expand Down
Loading