Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pydocumentdb in install_requires #1629

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

Inhenn
Copy link
Collaborator

@Inhenn Inhenn commented Feb 1, 2022

will not be supported soon

Description

removed pydocumentdb in install_requires

because of pydocumentdb retirement

Related Issues

#1393

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

will not be supported soon
Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy first commit @Inhenn, I'll add you to the repo so it is easier for you to do commits without forking

@codecov-commenter
Copy link

Codecov Report

Merging #1629 (a4a5070) into staging (1fee90e) will increase coverage by 57.73%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           staging    #1629       +/-   ##
============================================
+ Coverage     0.00%   57.73%   +57.73%     
============================================
  Files           88       88               
  Lines         9091     9091               
============================================
+ Hits             0     5249     +5249     
- Misses           0     3842     +3842     
Flag Coverage Δ
nightly ?
pr-gate 57.73% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
recommenders/datasets/mind.py 0.00% <0.00%> (ø)
recommenders/datasets/movielens.py 69.46% <0.00%> (+69.46%) ⬆️
recommenders/models/sasrec/model.py 26.28% <0.00%> (+26.28%) ⬆️
recommenders/datasets/download_utils.py 90.00% <0.00%> (+90.00%) ⬆️
recommenders/models/newsrec/models/npa.py 95.58% <0.00%> (+95.58%) ⬆️
recommenders/models/newsrec/models/naml.py 92.43% <0.00%> (+92.43%) ⬆️
recommenders/models/newsrec/models/nrms.py 91.37% <0.00%> (+91.37%) ⬆️
recommenders/models/newsrec/models/lstur.py 87.14% <0.00%> (+87.14%) ⬆️
recommenders/evaluation/python_evaluation.py 93.68% <0.00%> (+93.68%) ⬆️
recommenders/models/newsrec/newsrec_utils.py 67.12% <0.00%> (+67.12%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fee90e...a4a5070. Read the comment docs.

@miguelgfierro miguelgfierro merged commit e92c880 into recommenders-team:staging Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants