Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightly workflows #1576

Merged
merged 3 commits into from
Dec 9, 2021
Merged

Fix nightly workflows #1576

merged 3 commits into from
Dec 9, 2021

Conversation

anargyri
Copy link
Collaborator

@anargyri anargyri commented Dec 9, 2021

Description

  • Fix smoke and integrations workflows by removing experimental tests.
  • Fix ADO pipelines for CPU and GPU.

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2021

Codecov Report

Merging #1576 (a576983) into staging (d83753d) will decrease coverage by 0.32%.
The diff coverage is 72.22%.

Impacted file tree graph

@@             Coverage Diff             @@
##           staging    #1576      +/-   ##
===========================================
- Coverage    62.20%   61.88%   -0.33%     
===========================================
  Files           84       84              
  Lines         8441     8458      +17     
===========================================
- Hits          5251     5234      -17     
- Misses        3190     3224      +34     
Flag Coverage Δ
pr-gate 61.88% <72.22%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
recommenders/datasets/cosmos_cli.py 0.00% <ø> (ø)
recommenders/datasets/criteo.py 86.79% <0.00%> (ø)
recommenders/datasets/download_utils.py 90.00% <ø> (-0.20%) ⬇️
recommenders/datasets/mind.py 0.00% <0.00%> (ø)
recommenders/datasets/sparse.py 90.47% <ø> (ø)
recommenders/datasets/split_utils.py 87.75% <ø> (-0.25%) ⬇️
recommenders/evaluation/python_evaluation.py 93.68% <ø> (ø)
recommenders/evaluation/spark_evaluation.py 86.60% <ø> (-0.06%) ⬇️
...ecommenders/models/deeprec/DataModel/ImplicitCF.py 80.68% <ø> (-0.22%) ⬇️
...ommenders/models/deeprec/models/sequential/asvd.py 0.00% <0.00%> (ø)
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09973a1...a576983. Read the comment docs.

Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@anargyri
Copy link
Collaborator Author

anargyri commented Dec 9, 2021

awesome!

Let's see if it works tonight.

@miguelgfierro
Copy link
Collaborator

Let's see if it works tonight.

small note: this code won't execute in the nightly of staging until it is merged in staging

@anargyri anargyri merged commit 9d2c083 into staging Dec 9, 2021
@miguelgfierro miguelgfierro deleted the andreas/nightly branch December 11, 2021 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants