Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous Pipeline Fixes #1545

Merged
merged 7 commits into from
Oct 14, 2021
Merged

Miscellaneous Pipeline Fixes #1545

merged 7 commits into from
Oct 14, 2021

Conversation

laserprec
Copy link
Contributor

@laserprec laserprec commented Oct 6, 2021

Description

  1. Fix broken codecov report with explicit flags separating code coverage for the 2 builds (pr-gate & nightly)
    • We (should) no longer see random increase/decrease in code coverage numbers.
  2. Change codecov PR comment behavior to avoid email spam (sorry about that 😃)
  3. Add markers to flaky tests and rerun them.
  4. Add a notice for potential new release whenever there's a change to setup.py

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@laserprec laserprec changed the base branch from main to staging October 6, 2021 20:44
@laserprec laserprec changed the base branch from staging to main October 7, 2021 20:30
@laserprec laserprec force-pushed the laserprec/pipeline_fix branch 2 times, most recently from ab0e1c9 to 2ee8450 Compare October 7, 2021 20:38
@laserprec laserprec changed the base branch from main to staging October 7, 2021 20:42
@laserprec laserprec changed the base branch from staging to main October 7, 2021 20:46
@laserprec laserprec changed the base branch from main to staging October 7, 2021 20:56
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2021

Codecov Report

Merging #1545 (6f2a570) into staging (8d878aa) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           staging    #1545   +/-   ##
========================================
  Coverage    62.07%   62.07%           
========================================
  Files           84       84           
  Lines         8492     8492           
========================================
  Hits          5271     5271           
  Misses        3221     3221           
Flag Coverage Δ
pr-gate 62.07% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a485784...6f2a570. Read the comment docs.

@laserprec laserprec marked this pull request as ready for review October 12, 2021 20:56
@laserprec laserprec changed the title Miscellaneous Pipeline Fixes (draft) Miscellaneous Pipeline Fixes Oct 12, 2021
@laserprec laserprec merged commit 2a426d7 into staging Oct 14, 2021
@laserprec laserprec deleted the laserprec/pipeline_fix branch October 14, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants