Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standard VAE and Multinomial VAE notebooks correct typos #1239

Merged
merged 8 commits into from
Nov 12, 2020
Merged

Standard VAE and Multinomial VAE notebooks correct typos #1239

merged 8 commits into from
Nov 12, 2020

Conversation

EvgeniaChroni
Copy link
Contributor

@EvgeniaChroni EvgeniaChroni commented Nov 10, 2020 •
edited
Loading

Description

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging and not master.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@ghost
Copy link

ghost commented Nov 10, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@miguelgfierro
Copy link
Collaborator

@EvgeniaChroni there has been a problem with your PR and it took code from other people. Would you please do a branch from the latest staging, make the changes, and then do a PR to staging again?

@EvgeniaChroni EvgeniaChroni changed the base branch from master to staging November 11, 2020 12:41
@EvgeniaChroni EvgeniaChroni changed the title Evgenia chroni/vae Standard VAE and Multinomial VAE notebooks correct typos Nov 11, 2020
@EvgeniaChroni
Copy link
Contributor Author

@EvgeniaChroni there has been a problem with your PR and it took code from other people. Would you please do a branch from the latest staging, make the changes, and then do a PR to staging again?

Is everything ok now ?

miguelgfierro
miguelgfierro approved these changes Nov 12, 2020
View reviewed changes
Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miguelgfierro miguelgfierro merged commit 57f8e2c into recommenders-team:staging Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anargyri anargyri anargyri approved these changes

@miguelgfierro miguelgfierro miguelgfierro approved these changes

@gramhagen gramhagen Awaiting requested review from gramhagen gramhagen is a code owner

@loomlike loomlike Awaiting requested review from loomlike loomlike is a code owner

@wutaomsft wutaomsft Awaiting requested review from wutaomsft wutaomsft is a code owner

@yueguoguo yueguoguo Awaiting requested review from yueguoguo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EvgeniaChroni @miguelgfierro @anargyri