Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #970 #1011

Merged
merged 2 commits into from
Dec 16, 2019
Merged

Fix for issue #970 #1011

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e9aaf9
fix for Issue #970
elogicaadith Dec 12, 2019
c4ba08f
Fix for issue #970 - model directory obtained by using os.path.join
elogicaadith Dec 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion reco_utils/recommender/deeprec/models/base_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Copyright (c) Microsoft Corporation. All rights reserved.
# Licensed under the MIT License.

from os.path import join
import abc
import time
import numpy as np
Expand Down Expand Up @@ -406,9 +407,10 @@ def fit(self, train_file, valid_file, test_file=None):

if self.hparams.save_model:
if epoch % self.hparams.save_epoch == 0:
save_path_str = join(self.hparams.MODEL_DIR, "epoch_" + str(epoch))
checkpoint_path = self.saver.save(
sess=train_sess,
save_path=self.hparams.MODEL_DIR + "epoch_" + str(epoch),
save_path = save_path_str,
)

eval_start = time.time()
Expand Down