Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Papermill Record is deprecated in Papermill 1.0 and has been replaced by scrapbook #641

Closed
bethz opened this issue Mar 12, 2019 · 7 comments

Comments

@bethz
Copy link
Collaborator

bethz commented Mar 12, 2019

Description

This applies to any notebook using pm.record to capture logs.

In which platform does it happen?

this applies to all platforms and any notebook using papermill.record

How do we replicate the issue?

Run the SARS notebook.
The last cell uses pm.record and generates a warning:
/data/anaconda/envs/reco_full/lib/python3.6/site-packages/ipykernel_launcher.py:3: DeprecationWarning: Function record is deprecated and will be removed in verison 1.0.0 (current version 0.19.0). Please see scrapbook.glue (nteract-scrapbook) as a replacement for this functionality.
This is separate from the ipykernel package so we can avoid doing imports until

Expected behavior (i.e. solution)

Other Comments

Scrapbook does not appear to be a drop in replacement for pm.record .

@heatherbshapiro
Copy link
Contributor

Should we pin the release version until we can get a fix for this?

@gramhagen
Copy link
Collaborator

yeah, sounds good

@wutaomsft
Copy link
Contributor

+1 to fix this as this is breaking notebooks now that papermill 1.0 is out @gramhagen @yueguoguo

@gramhagen
Copy link
Collaborator

We have locked down the version to 0.18.2, so this shouldn't cause is trouble. But yeah we should prioritize switching off to minimize changes as new notebooks are added.

@wutaomsft
Copy link
Contributor

wutaomsft commented Apr 27, 2019 via email

@gramhagen
Copy link
Collaborator

gramhagen commented Apr 27, 2019 via email

@wutaomsft
Copy link
Contributor

wutaomsft commented Apr 27, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants