fix: #231 fix change password flow #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
dannd4,
nphivu414,
phmngocnghia,
trankhacvy,
vuhuucuong and
willmcvay
willmcvay
requested changes
Feb 13, 2020
| @@ -33,6 +31,8 @@ jest.mock('../../core/router', () => ({ | |||
| }, | |||
| })) | |||
|
|
|||
| const { MARKETPLACE_COGNITO_CLIENT_ID = '' } = process.env | |||
There was a problem hiding this comment.
2 things,
- The value is
COGNITO_CLIENT_ID_MARKETPLACEso this will not work - Deconstructing process.env object is fine locally but breaks in prod. Can you just reference
process.env.COGNITO_CLIENT_ID_MARKETPLACEplease
There was a problem hiding this comment.
I've updated new changes
Replace the string 'coggnitoClientId' with the actual env in saga
duong-se
force-pushed
the
fix/231-change-password
branch
from
1fe9594 to
91e40e6
Compare
phmngocnghia
approved these changes
Feb 13, 2020
phmngocnghia
pushed a commit
that referenced
this pull request
Feb 14, 2020
Replace the string 'coggnitoClientId' with the actual env in saga
nphivu414
pushed a commit
that referenced
this pull request
Apr 29, 2020
* [CLD-689] fix modal initial state * [CLD-689] update chaining fallback
nphivu414
pushed a commit
that referenced
this pull request
Apr 29, 2020
Replace the string 'coggnitoClientId' with the actual env in saga
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #231
Replace the string 'coggnitoClientId' with the actual env in saga
Edit actions taken after password are reset